 Issue 29607560:
  Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com
    
  
    Issue 29607560:
  Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com| Index: templates/article.tmpl | 
| =================================================================== | 
| --- a/templates/article.tmpl | 
| +++ b/templates/article.tmpl | 
| @@ -31,32 +31,41 @@ | 
| {{ title | translate( get_page_name(page) + "-title", "Article title") }} | 
| </h1> | 
| </header> | 
| {% if hide_browser_selector is not defined %} | 
| <div class="article-browser-selector"> | 
| <? include browser-select ?> | 
| </div> | 
| + | 
| + <div id="no-content-for-platform-message" class="content" hidden> | 
| + <p>{{ "Oops! There is no article for the subject and browser that you have selected. Please find a list of browsers that this article is available for below." | translate("no-content-for-platform-message", "paragraph") }}</p> | 
| 
juliandoucette
2017/12/11 15:15:28
TOL: The paragraph description is arguably the ~de
 
juliandoucette
2017/12/11 15:15:29
NIT/TOL: This is arguably more of a "notice" than
 
ire
2017/12/12 10:21:14
Ack. I think "notice" works.
 
ire
2017/12/12 10:21:14
Done.
 | 
| + <ul> | 
| + {% for browser in browsers %} | 
| + <li data-value="{{ browser.id }}"> | 
| + <button type="button" class="button-link"> | 
| + {{ browser.name | translate(browser.id + "-name") }} | 
| + </button> | 
| + </li> | 
| + {% endfor %} | 
| + </ul> | 
| + </div> | 
| {% endif %} | 
| <div class="article-body content"> | 
| {{ body | safe }} | 
| </div> | 
| </article> | 
| </div> | 
| <aside class="section column one-third"> | 
| <? include product-topics-accordion ?> | 
| </aside> | 
| </div> | 
| </main> | 
| - | 
| -<script id="no-content-for-platform-message" type="text/template"> | 
| - <p>{{ "Unfortunately, there is no content specific for your current browser. Please use the dropdown menu above to choose a different browser." | translate("no-content-for-platform-message", "paragraph") }}</p> | 
| -</script> | 
| {% endblock %} | 
| {% block footer %} | 
| <? include contact ?> | 
| {% endblock %} | 
| {% block scripts %} | 
| <script src="/js/vendor/bowser.js"></script> |