Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)

Issue 29608576: Issue 6036 - Use correct resolution for devtools pane icon (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by kzar
Modified:
1 year, 10 months ago
Visibility:
Public.

Description

Issue 6036 - Use correct resolution for devtools pane icon This makes the icon much sharper on Firefox (see https://issues.adblockplus.org/attachment/ticket/6036/6036-blury-devtools-icon.png ), but I'm not sure if it's the correct resolution for other platforms. I have never seen this icon displayed on Chrome, nor could figure out how to enable it being displayed for example.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switch to 32px icon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M devtools.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
1 year, 10 months ago (2017-11-14 15:54:13 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js File devtools.js (right): https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js#newcode38 devtools.js:38: "icons/abp-16.png", This API apparently accepts one icon size only, ...
1 year, 10 months ago (2017-11-17 12:35:41 UTC) #2
kzar
Patch Set 2 : Switch to 32px icon https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js File devtools.js (right): https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js#newcode38 devtools.js:38: "icons/abp-16.png", ...
1 year, 10 months ago (2017-11-17 14:22:26 UTC) #3
Wladimir Palant
1 year, 10 months ago (2017-11-17 20:49:03 UTC) #4
LGTM

Firefox should supports SVG btw, but I don't think we can rely on that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5