Issue 6036 - Use correct resolution for devtools pane icon

Issue 6036 - Use correct resolution for devtools pane icon


This makes the icon much sharper on Firefox (see https://issues.adblockplus.org/attachment/ticket/6036/6036-blury-devtools-icon.png ), but I'm not sure if it's the correct resolution for other platforms. I have never seen this icon displayed on Chrome, nor could figure out how to enable it being displayed for example.

[kzar, 2017-11-14 15:54:13]

Patch Set 1

[Wladimir Palant, 2017-11-17 12:35:41]

https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js
File devtools.js (right):

https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js#newcode38
devtools.js:38: "icons/abp-16.png",
This API apparently accepts one icon size only, this is wrong... Either way, I
couldn't find any place where Chrome would display this icon, so I guess that
size doesn't matter there. We should use abp-32.png on Firefox however, this
will look much better on hi-DPI screens while still being ok if scaled down.

[kzar, 2017-11-17 14:22:26]

Patch Set 2 : Switch to 32px icon

https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js
File devtools.js (right):

https://codereview.adblockplus.org/29608576/diff/29608577/devtools.js#newcode38
devtools.js:38: "icons/abp-16.png",
On 2017/11/17 12:35:41, Wladimir Palant wrote:
> This API apparently accepts one icon size only, this is wrong... Either way, I
> couldn't find any place where Chrome would display this icon, so I guess that
> size doesn't matter there. We should use abp-32.png on Firefox however, this
> will look much better on hi-DPI screens while still being ok if scaled down.

You're right, 32px doesn't look quite as good on my laptop's screen but on my
friend's retina mac screen it looks much sharper. Done.

[Wladimir Palant, 2017-11-17 20:49:03]

LGTM

Firefox should supports SVG btw, but I don't think we can rely on that.