Issue 6021 - Refactoring build.py

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import argparse
 import logging
 import os
 import re
 import shutil
 import subprocess
@@ skipping 78 matching lines @@
         logging.error('No metadata file found in this repository. Expecting '
                       'one or more of {} to be present.'.format(
                           ', '.join('metadata.' + p for p in KNOWN_PLATFORMS)))
         build_available_subcommands._result = False
         return False
 
     for command_params in ALL_COMMANDS:
         platforms = types.intersection(command_params.pop('valid_platforms'))
         if len(platforms) > 1:
             command_params['arguments'] += (
-                make_argument('-t', '--type', dest='platform',
+                make_argument('-t', '--type', dest='platform', required=True,
                               choices=platforms),
             )
             make_subcommand(**command_params)
         elif len(platforms) == 1:
             sub_parser = make_subcommand(**command_params)
             sub_parser.set_defaults(platform=platforms.pop())
 
     build_available_subcommands._result = True
     return True
 
@@ skipping 179 matching lines @@
     locale_config = read_locale_config(base_dir, platform, metadata)
 
     import buildtools.localeTools as localeTools
     localeTools.getTranslations(locale_config, basename, project_key)
 
 
 @argparse_command(
     valid_platforms={'chrome'},
     arguments=(
         make_argument('target_dir'),
-        make_argument('-q', '--quiet', help='Suppress JsDoc output'),
+        make_argument('-q', '--quiet', help='Suppress JsDoc output',
+                      action='store_true', default=False),
     )
 )
 def docs(base_dir, target_dir, quiet, platform, **kwargs):
     """
     Generate documentation (requires node.js).
 
     Generate documentation files and write them into the specified directory.
     """
     source_dir = os.path.join(base_dir, 'lib')
 
@@ skipping 81 matching lines @@
     if build_available_subcommands(base_dir):
         MAIN_PARSER.set_defaults(base_dir=base_dir)
 
         # If no args are provided, this module is run directly from the command
         # line. argparse will take care of consuming sys.argv.
         arguments = MAIN_PARSER.parse_args(args if len(args) > 0 else None)
 
         function = arguments.function
         del arguments.function
         function(**vars(arguments))