Issue 6031 - Implement Acceptable Ads notification

skin/desktop-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 602 matching lines @@
 
 section.cols > *:last-child
 {
   flex: 3;
 }
 
 /*
   Acceptable ads
  */
 
+#acceptable-ads.show-notification #tracking-notification

[Thomas Greiner, 2017/11/16 19:25:06]

Suggestion: You could avoid setting "display" twice and you wouldn't need to
care about its value if you use `:not()`.

i.e.
#acceptable-ads:not(.show-notification) #tracking-notification
{
  display: none;
}

[saroyanm, 2017/11/17 16:10:39]

Right, done.

+{
+  display: block;
+}
+
+#tracking-notification
+{
+  position: relative;
+  display: none;
+  padding: 1.5rem;
+  margin-bottom: 1rem;
+  border: 2px solid #ffd7a3;
+  background-color: #fefbe3;

[Thomas Greiner, 2017/11/16 19:25:05]

Detail: These colors aren't mentioned in the style guide so we should add them
to the spec.

[saroyanm, 2017/11/17 16:10:39]

Yes in general style guide for this notification is missing from the pull
request. ->
https://bitbucket.org/adblockplus/spec/pull-requests/81/issue-87-new-proposal...

[Thomas Greiner, 2017/11/20 18:36:04]

Acknowledged.

+}
+
+#hide-tracking-notification
+{
+  position: absolute;
+  right: 1rem;

[Thomas Greiner, 2017/11/16 19:25:06]

What about right-to-left environments?

[saroyanm, 2017/11/17 16:10:39]

Done.

+  top: 1rem;
+}
+
+#tracking-notification .link

[Thomas Greiner, 2017/11/16 19:25:06]

Detail: Links also use `cursor: pointer`.

Alternatively, we could use a `<a>` element instead of a `<button>` here.

[saroyanm, 2017/11/17 16:10:39]

`cursor: pointer` is inherited from the class `button`. 
I don't think that we should use `<a>` here, as semantically this is a button
which looks like a link. Similar to the `About Adblock Plus` button in the
sidebar, while for example `Contribute` which looks like a button, is actually a
link,  I tried to be here consistent to that logic.

[Thomas Greiner, 2017/11/20 18:36:04]

Indeed, I missed that.

+{
+  color: inherit;
+  text-decoration: underline;
+  font-weight: 700;
+}
+
 #acceptable-ads ul
 {
   position: relative;
   padding-left: 2rem;
   list-style: none;
 }
 
 html[dir="rtl"] #acceptable-ads ul
 {
   padding-left: 0rem;
   padding-right: 2rem;
 }
 
-#acceptable-ads button
+#acceptable-ads ul button
 {
   position: absolute;
   margin-top: 0.3rem;
   left: 0rem;
 }
 
 html[dir="rtl"] button
 {
   left: auto;
   right: 0rem;
@@ skipping 253 matching lines @@
 .tooltip::before
 {
   content: "";
   width: 1.3rem;
   height: 1.3rem;
   display: block;
   background-image: url(icons/tooltip.svg);
 }
 
 /* 
   Used for translatable screen reader only conten.

[Thomas Greiner, 2017/11/16 19:25:06]

Typo: Replace "conten" with "content".

[saroyanm, 2017/11/17 16:10:39]

Done.

   e.g.: Use instead of aria-label to avoid complex attribute value translation
 */
 .sr-only
 {
   position: absolute;
   overflow: hidden;
   clip: rect(0, 0, 0, 0);
   width: 1px;
   height: 1px;
   margin: -1px;
@@ skipping 369 matching lines @@
 }
 
 #dialog header h3
 {
   margin: 0rem;
   font-size: 1.375rem;
   font-weight: 700;
 }
 
 #dialog-close,
-#hide-notification
+#hide-notification,
+#hide-tracking-notification
 {
   border: 0rem;
   padding: 0rem;
   margin: 0rem;
   background-color: transparent;
   cursor: pointer;
 }
 
 #dialog-close::before,
-#hide-notification::after
+#hide-notification::after,
+#hide-tracking-notification::after
 {
   content: "";
   display: block;
   height: 1rem;
   width: 1rem;
   border: 0rem;
   background-image: url(icons/delete.svg#primary);
 }
 
 #dialog-close:hover::before
@@ skipping 116 matching lines @@
 #hide-notification
 {
   margin: 0rem 1rem;
 }
 
 #hide-notification::after
 {
   background-image: url(icons/delete.svg#secondary);
 }
 
+#hide-tracking-notification::after
+{
+  background-image: url(icons/delete.svg#tertiary);
+}
+
 #hide-notification:hover::after
 {
   background-image: url(icons/delete.svg#secondary-hover);
 }
+
+#hide-tracking-notification:hover::after
+{
+  background-image: url(icons/delete.svg#tertiary-hover);
+}