Issue 6031 - Implement Acceptable Ads notification

desktop-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 10 matching lines @@
 "use strict";
 
 {
   let subscriptionsMap = Object.create(null);
   let filtersMap = Object.create(null);
   let collections = Object.create(null);
   let acceptableAdsUrl = null;
   let acceptableAdsPrivacyUrl = null;
   let isCustomFiltersLoaded = false;
   let {getMessage} = browser.i18n;
+  let {setElementText} = ext.i18n;
   let customFilters = [];
   let filterErrors = new Map([
     ["synchronize_invalid_url",
      "options_filterList_lastDownload_invalidURL"],
     ["synchronize_connection_error",
      "options_filterList_lastDownload_connectionError"],
     ["synchronize_invalid_data",
      "options_filterList_lastDownload_invalidData"],
     ["synchronize_checksum_mismatch",
      "options_filterList_lastDownload_checksumMismatch"]
@@ skipping 559 matching lines @@
         break;
       case "edit-custom-filters":
         setCustomFiltersView("write");
         break;
       case "hide-more-filters-section":
         E("more-filters").setAttribute("aria-hidden", true);
         break;
       case "hide-notification":
         hideNotification();
         break;
-      case "hide-tracking-notification":
-        E("acceptable-ads").classList.remove("show-notification");

[Thomas Greiner, 2017/11/16 19:25:05]

Let's remove this action and instead react to changes to "ui_warn_tracking"
(similar to the way we react to subscription changes in
`onSubscriptionMessage()`) so that we keep the UI in sync with the state of the
extension.

Also, I don't see "ui_warn_tracking" being handled in `onPrefMessage()` even
though you're listening to its changes.

[saroyanm, 2017/11/17 16:10:38]

I agree, done.

-        break;
       case "import-subscription": {
         let url = E("blockingList-textbox").value;
         addEnableSubscription(url);
         closeDialog();
         break;
       }
       case "open-context-menu": {
         let listItem = findParentData(element, "access", true);
         if (listItem && !listItem.classList.contains("show-context-menu"))
           listItem.classList.add("show-context-menu");
@@ skipping 280 matching lines @@
 
     // General tab
     getDocLink("contribute", (link) =>
     {
       E("contribute").href = link;
     });
     getDocLink("acceptable_ads_criteria", (link) =>
     {
       setLinks("enable-acceptable-ads-description", link);
     });
+    setElementText(E("tracking-warning-1"), "options_tracking_warning_1", 
+      [getMessage("common_feature_privacy_title"),
+      getMessage("options_acceptableAds_ads_label")]);
+    setElementText(E("tracking-warning-3"), "options_tracking_warning_3", 
+      [getMessage("options_acceptableAds_privacy_label")]);
+
     getDocLink("privacy_friendly_ads", (link) =>
     {
       E("enable-acceptable-ads-privacy-description").href = link;
     });
     getDocLink("adblock_plus_{browser}_dnt", url =>
     {
       setLinks("dnt", url);
     });
 
     // Whitelisted tab
@@ skipping 363 matching lines @@
 
         if (isAcceptableAds(url))
           setAcceptableAds();
 
         if ((url == acceptableAdsUrl || recommended == "privacy") &&
           hasPrivacyConflict())
         {
           getPref("ui_warn_tracking", (showTrackingWarning) =>
           {
             if (showTrackingWarning)
-              E("acceptable-ads").classList.add("show-notification");
+              E("acceptable-ads").classList.add("show-warning");
           });
         }
 
         collections.filterLists.addItem(subscription);
         break;
       case "removed":
         if (subscription.recommended)
         {
           subscription.disabled = true;
           onSubscriptionMessage("disabled", subscription);
@@ skipping 56 matching lines @@
   function onPrefMessage(key, value, initial)
   {
     switch (key)
     {
       case "notifications_ignoredcategories":
         value = value.indexOf("*") == -1;
         break;
 
       case "notifications_showui":
         hidePref("notifications_ignoredcategories", !value);
+        break;
+      case "ui_warn_tracking":
+        let showWarning = (value && hasPrivacyConflict());
+        E("acceptable-ads").classList.toggle("show-warning", showWarning);
         break;
     }
 
     let checkbox = document.querySelector(
       "[data-pref='" + key + "'] button[role='checkbox']"
     );
     if (checkbox)
       checkbox.setAttribute("aria-checked", value);
   }
 
@@ skipping 67 matching lines @@
   });
   browser.runtime.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
              "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 }