Unified Diff: desktop-options.html
Issue 29609587:
Issue 6031 - Implement Acceptable Ads notification (Closed)
Patch Set: Addressed Thomas comments
Created Nov. 17, 2017, 4:03 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« background.js ('k')
|
desktop-options.js » ('j')
|
desktop-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: desktop-options.html |
| =================================================================== |
| --- a/desktop-options.html |
| +++ b/desktop-options.html |
| @@ -97,6 +97,15 @@ |
| <p class="i18n_options_acceptableAds_description"></p> |
| </header> |
| <form id="acceptable-ads"> |
| + <div id="tracking-warning"> |
| + <button id="hide-tracking-warning" type="button" data-pref="ui_warn_tracking" data-action="toggle-pref"> |
| + <span class="i18n_options_notification_hide sr-only"></span> |
| + </button> |
| + <p id="tracking-warning-1"></p> |
| + <p class="i18n_options_tracking_warning_2"></p> |
| + <p id="tracking-warning-3" class="i18n_options_tracking_warning_3"></p> |
|
Thomas Greiner
2017/11/20 18:36:04
Detail: The "i18n_*" class here is redundant becau
saroyanm
2017/11/21 14:58:32
Done.
|
| + <button class="i18n_options_tracking_warning_acknowledgment link" type="button" data-pref="ui_warn_tracking" data-action="toggle-pref"></button> |
| + </div> |
| <ul> |
| <li> |
| <button id="acceptable-ads-allow" data-action="switch-acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button> |
« no previous file with comments
|
« background.js ('k')
|
desktop-options.js » ('j')
|
desktop-options.js » ('J')
