Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: skin/desktop-options.css

Issue 29611615: Issue 5990 - Fix broken SVG icons in Chrome (Closed)
Patch Set: Created Nov. 17, 2017, 4:40 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 { 174 {
175 width: 1.2rem; 175 width: 1.2rem;
176 height: 1.2rem; 176 height: 1.2rem;
177 padding: 0px; 177 padding: 0px;
178 border: 0px; 178 border: 0px;
179 background-color: transparent; 179 background-color: transparent;
180 } 180 }
181 181
182 button[role="checkbox"]:not(.toggle) 182 button[role="checkbox"]:not(.toggle)
183 { 183 {
184 background-image: url(icons/checkbox.svg#off); 184 /* Using ?query as a workaround to chromium bug #643716 */
185 background-image: url(icons/checkbox.svg?1#off);
Thomas Greiner 2017/11/20 17:39:06 Rather than using arbitrary numbers which could mi
saroyanm 2017/11/20 18:42:25 I agree, done.
185 display: inline-block; 186 display: inline-block;
186 } 187 }
187 188
188 button[role="checkbox"][aria-checked="true"]:not(.toggle) 189 button[role="checkbox"][aria-checked="true"]:not(.toggle)
189 { 190 {
190 background-image: url(icons/checkbox.svg#on); 191 background-image: url(icons/checkbox.svg?2#on);
191 } 192 }
192 193
193 button[role="checkbox"][disabled], 194 button[role="checkbox"][disabled],
194 button[role="checkbox"][aria-disabled="true"] 195 button[role="checkbox"][aria-disabled="true"]
195 { 196 {
196 border-radius: 2px; 197 border-radius: 2px;
197 background-color: #ccc; 198 background-color: #ccc;
198 } 199 }
199 200
200 button[role="checkbox"].toggle 201 button[role="checkbox"].toggle
201 { 202 {
202 background: url(icons/toggle.svg#on); 203 background-image: url(icons/toggle.svg?1#on);
203 } 204 }
204 205
205 button[role="checkbox"][aria-checked="false"].toggle 206 button[role="checkbox"][aria-checked="false"].toggle
206 { 207 {
207 background: url(icons/toggle.svg#off); 208 background-image: url(icons/toggle.svg?2#off);
208 } 209 }
209 210
210 button[role="checkbox"][aria-checked="true"].toggle 211 button[role="checkbox"][aria-checked="true"].toggle
211 { 212 {
212 background: url(icons/toggle.svg#on); 213 background-image: url(icons/toggle.svg?3#on);
213 } 214 }
214 215
215 button[role="checkbox"].toggle 216 button[role="checkbox"].toggle
216 { 217 {
217 background-position: initial; 218 background-position: initial;
218 width: 1.9rem; 219 width: 1.9rem;
219 height: 1rem; 220 height: 1rem;
220 vertical-align: middle; 221 vertical-align: middle;
221 } 222 }
222 223
223 button[role="checkbox"][disabled].toggle 224 button[role="checkbox"][disabled].toggle
224 { 225 {
225 background-image: none; 226 background-image: none;
226 } 227 }
227 228
228 button.delete::before 229 button.delete::before
229 { 230 {
230 background-image: url(icons/trash.svg#default); 231 background-image: url(icons/trash.svg?1#default);
231 } 232 }
232 233
233 button.delete:hover::before 234 button.delete:hover::before
234 { 235 {
235 background-image: url(icons/trash.svg#hover); 236 background-image: url(icons/trash.svg?2#hover);
236 } 237 }
237 238
238 button.gear::before 239 button.gear::before
239 { 240 {
240 background-image: url(icons/gear.svg#default); 241 background-image: url(icons/gear.svg?1#default);
241 } 242 }
242 243
243 button.gear:hover::before 244 button.gear:hover::before
244 { 245 {
245 background-image: url(icons/gear.svg#hover); 246 background-image: url(icons/gear.svg?2#hover);
246 } 247 }
247 248
248 button.gear, 249 button.gear,
249 button.delete 250 button.delete
250 { 251 {
251 border: 0px; 252 border: 0px;
252 padding: 0px; 253 padding: 0px;
253 background-color: transparent; 254 background-color: transparent;
254 } 255 }
255 256
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 } 398 }
398 399
399 [data-validation] .floating-input input:focus:invalid ~ .attention::before 400 [data-validation] .floating-input input:focus:invalid ~ .attention::before
400 { 401 {
401 background-image: url(icons/attention.svg); 402 background-image: url(icons/attention.svg);
402 } 403 }
403 404
404 [data-validation] .floating-input input:valid ~ .attention::before 405 [data-validation] .floating-input input:valid ~ .attention::before
405 { 406 {
406 top: 0.5rem; 407 top: 0.5rem;
407 background-image: url(icons/checkmark.svg#approved); 408 background-image: url(icons/checkmark.svg?1#approved);
408 } 409 }
409 410
410 [data-validation] .floating-input input ~ .error-msg 411 [data-validation] .floating-input input ~ .error-msg
411 { 412 {
412 margin-top: 0.5rem; 413 margin-top: 0.5rem;
413 color: #C11D27; 414 color: #C11D27;
414 display: block; 415 display: block;
415 visibility: hidden; 416 visibility: hidden;
416 } 417 }
417 418
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 #dialog .table.list li button[aria-checked="true"] 894 #dialog .table.list li button[aria-checked="true"]
894 { 895 {
895 color: #BBB; 896 color: #BBB;
896 } 897 }
897 898
898 #dialog .table.list li button[aria-checked="true"]::before 899 #dialog .table.list li button[aria-checked="true"]::before
899 { 900 {
900 content: ""; 901 content: "";
901 width: 1.3rem; 902 width: 1.3rem;
902 height: 1.3rem; 903 height: 1.3rem;
903 background-image: url(icons/checkmark.svg#default); 904 background-image: url(icons/checkmark.svg?2#default);
904 margin: 0rem; 905 margin: 0rem;
905 } 906 }
906 907
907 #dialog .table.list li button .display 908 #dialog .table.list li button .display
908 { 909 {
909 flex: none; 910 flex: none;
910 margin: 0rem 0.8rem; 911 margin: 0rem 0.8rem;
911 text-transform: none; 912 text-transform: none;
912 font-weight: 400; 913 font-weight: 400;
913 } 914 }
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1221 background-image: url(icons/globe.svg); 1222 background-image: url(icons/globe.svg);
1222 } 1223 }
1223 1224
1224 .context-menu .source::before 1225 .context-menu .source::before
1225 { 1226 {
1226 background-image: url(icons/code.svg); 1227 background-image: url(icons/code.svg);
1227 } 1228 }
1228 1229
1229 .context-menu .delete::before 1230 .context-menu .delete::before
1230 { 1231 {
1231 background-image: url(icons/trash.svg#default); 1232 background-image: url(icons/trash.svg?3#default);
1232 } 1233 }
1233 1234
1234 /* 1235 /*
1235 Help tab content 1236 Help tab content
1236 */ 1237 */
1237 1238
1238 html:not([lang="zh"]) #social-chinese, 1239 html:not([lang="zh"]) #social-chinese,
1239 html[lang="zh"] #social-general 1240 html[lang="zh"] #social-general
1240 { 1241 {
1241 display: none; 1242 display: none;
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
1345 } 1346 }
1346 1347
1347 #dialog-close::before, 1348 #dialog-close::before,
1348 #hide-notification::after 1349 #hide-notification::after
1349 { 1350 {
1350 content: ""; 1351 content: "";
1351 display: block; 1352 display: block;
1352 height: 1rem; 1353 height: 1rem;
1353 width: 1rem; 1354 width: 1rem;
1354 border: 0rem; 1355 border: 0rem;
1355 background-image: url(icons/delete.svg#primary); 1356 background-image: url(icons/delete.svg?1#primary);
1356 } 1357 }
1357 1358
1358 #dialog-close:hover::before 1359 #dialog-close:hover::before
1359 { 1360 {
1360 background-image: url(icons/delete.svg#primary-hover); 1361 background-image: url(icons/delete.svg?2#primary-hover);
1361 } 1362 }
1362 1363
1363 #dialog #dialog-body 1364 #dialog #dialog-body
1364 { 1365 {
1365 max-height: 60vh; 1366 max-height: 60vh;
1366 overflow: auto; 1367 overflow: auto;
1367 } 1368 }
1368 1369
1369 .dialog-content 1370 .dialog-content
1370 { 1371 {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 text-align: center; 1468 text-align: center;
1468 } 1469 }
1469 1470
1470 #hide-notification 1471 #hide-notification
1471 { 1472 {
1472 margin: 0rem 1rem; 1473 margin: 0rem 1rem;
1473 } 1474 }
1474 1475
1475 #hide-notification::after 1476 #hide-notification::after
1476 { 1477 {
1477 background-image: url(icons/delete.svg#secondary); 1478 background-image: url(icons/delete.svg?3#secondary);
1478 } 1479 }
1479 1480
1480 #hide-notification:hover::after 1481 #hide-notification:hover::after
1481 { 1482 {
1482 background-image: url(icons/delete.svg#secondary-hover); 1483 background-image: url(icons/delete.svg?4#secondary-hover);
1483 } 1484 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld