pages/uninstalled-submit.html - Issue 29611624: Issue 6047 - Updated templates and uninstalled pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: pages/uninstalled-submit.html

Issue 29611624: Issue 6047 - Updated templates and uninstalled pages (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Changed document macro in html-attribute include, removed simple template, and removed temporary/unused resources include Created Nov. 25, 2017, 1:35 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 title=Adblock Plus has been uninstalled	1 title=Adblock Plus has been uninstalled

2 template=simple	2 template=minimal

3	3

4 <head>	4 <head>

5 <meta name="robots" content="noindex" />	5 <meta name="robots" content="noindex" />

	6 <link rel="stylesheet" href="/css/uninstalled.css" type="text/css" media="all" >

6 </head>	7 </head>

7	8

8 <p class="notification">	9 <div class="container content">

9 <strong>	10 <h1>{{ heading[Heading text] Data submitted successfully }}</h1>

10 {{ reinstall-headline[Text next to the Reinstallation button] Did you uninst all Adblock Plus by accident? }}	11 <p>{{ thank-you[Thank you message below heading] Thank you for your participat ion }}</p>

11 </strong>	12 </div>

12 <a href="index">

13 {{ reinstall[Reinstall button text] Reinstall Now }}

14 </a>

15 </p>

16	13

17 <section markdown="1" class="highlighted">	14 <aside id="reinstall" class="bg-accent" >
	ire 2017/11/27 19:48:20 Suggest: Since this is used on multiple pages, mak Suggest: Since this is used on multiple pages, make it an include juliandoucette 2017/12/04 13:34:04 Agreed. Show quoted text On 2017/11/27 19:48:20, ire wrote: > Suggest: Since this is used on multiple pages, make it an include Agreed. ire 2017/12/07 12:36:26 You haven't done this yet. Show quoted text On 2017/12/04 13:34:04, juliandoucette wrote: > On 2017/11/27 19:48:20, ire wrote: > > Suggest: Since this is used on multiple pages, make it an include > > Agreed. You haven't done this yet. juliandoucette 2017/12/14 18:35:22 Done. Show quoted text On 2017/12/07 12:36:26, ire wrote: > On 2017/12/04 13:34:04, juliandoucette wrote: > > On 2017/11/27 19:48:20, ire wrote: > > > Suggest: Since this is used on multiple pages, make it an include > > > > Agreed. > > You haven't done this yet. Done.
18 #{{heading[Heading text] Data submitted successfully}}	15 <div class="container content">

19	16 <p class="lead">

20 {{thank-you[Thank you message below heading] Thank you for your participation}}	17 {{ reinstall-headline[Text next to the Reinstallation button] Did you uninst all Adblock Plus by accident?" }}
	ire 2017/11/27 19:48:20 Unintended quote mark at the end of this sentence Unintended quote mark at the end of this sentence juliandoucette 2017/12/04 13:34:04 Good catch. It's strange that this doesn't show in Show quoted text On 2017/11/27 19:48:20, ire wrote: > Unintended quote mark at the end of this sentence Good catch. It's strange that this doesn't show in the website. juliandoucette 2017/12/06 16:30:52 Done. Show quoted text On 2017/12/04 13:34:04, juliandoucette wrote: > On 2017/11/27 19:48:20, ire wrote: > > Unintended quote mark at the end of this sentence > > Good catch. It's strange that this doesn't show in the website. Done.
21 {: .subheader }	18 <a href="index" class="button">
	ire 2017/11/27 19:48:21 This button isn't styled correctly This button isn't styled correctly juliandoucette 2017/12/04 13:34:04 Correctly how? I styled it according to Paul's spe Show quoted text On 2017/11/27 19:48:21, ire wrote: > This button isn't styled correctly Correctly how? I styled it according to Paul's specification on IRC (not the style guide). ire 2017/12/05 10:28:00 Sorry I was going off the spec. Is Paul's change d Show quoted text On 2017/12/04 13:34:04, juliandoucette wrote: > On 2017/11/27 19:48:21, ire wrote: > > This button isn't styled correctly > > Correctly how? I styled it according to Paul's specification on IRC (not the > style guide). Sorry I was going off the spec. Is Paul's change documented anywhere? (Besides IRC) juliandoucette 2017/12/06 16:05:06 Unfortunately not. Show quoted text On 2017/12/05 10:28:00, ire wrote: > Sorry I was going off the spec. Is Paul's change documented anywhere? (Besides > IRC) Unfortunately not.
22 </section>	19 {{ reinstall[Reinstall button text] Reinstall Now }}

	20 </a>

	21 </div>

	22 </aside>

OLD	NEW

« pages/uninstalled.tmpl ('K') | « pages/uninstalled.tmpl ('k') | static/css/defaults.css » ('j') | static/css/main.css » ('J')