pages/uninstalled-submit.html - Issue 29611624: Issue 6047 - Updated templates and uninstalled pages

Delta Between Two Patch Sets: pages/uninstalled-submit.html

Issue 29611624: Issue 6047 - Updated templates and uninstalled pages (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Left Patch Set: Changed document macro in html-attribute include, removed simple template, and removed temporary/unused resources include Created Nov. 25, 2017, 1:35 p.m.

Right Patch Set: Addressed comments in #15 Created Dec. 18, 2017, 12:55 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 title=Adblock Plus has been uninstalled	1 title=Adblock Plus has been uninstalled

2 template=minimal	2 template=minimal

3	3

4 <head>	4 <head>

5 <meta name="robots" content="noindex" />	5 <meta name="robots" content="noindex" />

6 <link rel="stylesheet" href="/css/uninstalled.css" type="text/css" media="all" >	6 <link href="/css/uninstalled.css" rel="stylesheet">

7 </head>	7 </head>

8	8

9 <div class="container content">	9 <div id="content" class="container content">

10 <h1>{{ heading[Heading text] Data submitted successfully }}</h1>	10 <h1>{{ heading[Heading text] Data submitted successfully }}</h1>

11 <p>{{ thank-you[Thank you message below heading] Thank you for your participat ion }}</p>	11 <p class="lead">{{ thank-you[Thank you message below heading] Thank you for yo ur participation }}</p>

12 </div>	12 </div>

13	13

14 <aside id="reinstall" class="bg-accent" >	14 <? include reinstall ?>
ire 2017/11/27 19:48:20 Suggest: Since this is used on multiple pages, mak Suggest: Since this is used on multiple pages, make it an include juliandoucette 2017/12/04 13:34:04 Agreed. Show quoted text On 2017/11/27 19:48:20, ire wrote: > Suggest: Since this is used on multiple pages, make it an include Agreed. ire 2017/12/07 12:36:26 You haven't done this yet. Show quoted text On 2017/12/04 13:34:04, juliandoucette wrote: > On 2017/11/27 19:48:20, ire wrote: > > Suggest: Since this is used on multiple pages, make it an include > > Agreed. You haven't done this yet. juliandoucette 2017/12/14 18:35:22 Done. Show quoted text On 2017/12/07 12:36:26, ire wrote: > On 2017/12/04 13:34:04, juliandoucette wrote: > > On 2017/11/27 19:48:20, ire wrote: > > > Suggest: Since this is used on multiple pages, make it an include > > > > Agreed. > > You haven't done this yet. Done.
15 <div class="container content">

16 <p class="lead">

17 {{ reinstall-headline[Text next to the Reinstallation button] Did you uninst all Adblock Plus by accident?" }}
ire 2017/11/27 19:48:20 Unintended quote mark at the end of this sentence Unintended quote mark at the end of this sentence juliandoucette 2017/12/04 13:34:04 Good catch. It's strange that this doesn't show in Show quoted text On 2017/11/27 19:48:20, ire wrote: > Unintended quote mark at the end of this sentence Good catch. It's strange that this doesn't show in the website. juliandoucette 2017/12/06 16:30:52 Done. Show quoted text On 2017/12/04 13:34:04, juliandoucette wrote: > On 2017/11/27 19:48:20, ire wrote: > > Unintended quote mark at the end of this sentence > > Good catch. It's strange that this doesn't show in the website. Done.
18 <a href="index" class="button">
ire 2017/11/27 19:48:21 This button isn't styled correctly This button isn't styled correctly juliandoucette 2017/12/04 13:34:04 Correctly how? I styled it according to Paul's spe Show quoted text On 2017/11/27 19:48:21, ire wrote: > This button isn't styled correctly Correctly how? I styled it according to Paul's specification on IRC (not the style guide). ire 2017/12/05 10:28:00 Sorry I was going off the spec. Is Paul's change d Show quoted text On 2017/12/04 13:34:04, juliandoucette wrote: > On 2017/11/27 19:48:21, ire wrote: > > This button isn't styled correctly > > Correctly how? I styled it according to Paul's specification on IRC (not the > style guide). Sorry I was going off the spec. Is Paul's change documented anywhere? (Besides IRC) juliandoucette 2017/12/06 16:05:06 Unfortunately not. Show quoted text On 2017/12/05 10:28:00, ire wrote: > Sorry I was going off the spec. Is Paul's change documented anywhere? (Besides > IRC) Unfortunately not.
19 {{ reinstall[Reinstall button text] Reinstall Now }}

20 </a>

21 </div>

22 </aside>

LEFT	RIGHT