Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29612684: Issue 6060 - Provided lead style via website-defaults (Closed)

Created:
Nov. 20, 2017, 3:24 p.m. by juliandoucette
Modified:
Nov. 27, 2017, 2:33 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Added TOC item and reworded description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M pages/utilities.html View 1 2 chunks +7 lines, -0 lines 0 comments Download
M static/scss/_utilities.scss View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
juliandoucette
Nov. 20, 2017, 3:24 p.m. (2017-11-20 15:24:18 UTC) #1
ire
https://codereview.adblockplus.org/29612684/diff/29612685/pages/utilities.html File pages/utilities.html (right): https://codereview.adblockplus.org/29612684/diff/29612685/pages/utilities.html#newcode8 pages/utilities.html:8: <li><a href="#text-alignment">Text Alignment</a></li> You forgot to add the heading ...
Nov. 27, 2017, 8:46 a.m. (2017-11-27 08:46:44 UTC) #2
juliandoucette
https://codereview.adblockplus.org/29612684/diff/29612685/pages/utilities.html File pages/utilities.html (right): https://codereview.adblockplus.org/29612684/diff/29612685/pages/utilities.html#newcode8 pages/utilities.html:8: <li><a href="#text-alignment">Text Alignment</a></li> On 2017/11/27 08:46:43, ire wrote: > ...
Nov. 27, 2017, 1:11 p.m. (2017-11-27 13:11:46 UTC) #3
juliandoucette
Updated. https://codereview.adblockplus.org/29612684/diff/29612685/pages/utilities.html File pages/utilities.html (right): https://codereview.adblockplus.org/29612684/diff/29612685/pages/utilities.html#newcode8 pages/utilities.html:8: <li><a href="#text-alignment">Text Alignment</a></li> On 2017/11/27 08:46:43, ire wrote: ...
Nov. 27, 2017, 1:12 p.m. (2017-11-27 13:12:07 UTC) #4
ire
LGTM
Nov. 27, 2017, 2:08 p.m. (2017-11-27 14:08:34 UTC) #5
juliandoucette
Nov. 27, 2017, 2:33 p.m. (2017-11-27 14:33:35 UTC) #6
On 2017/11/27 14:08:34, ire wrote:
> LGTM

https://hg.adblockplus.org/website-defaults/rev/5dc8e66804f4

Powered by Google App Engine
This is Rietveld