compiled/filter/ElemHideEmulationFilter.cpp - Issue 29613616: Issue 6064 - Put C++ code into a configurable namespace

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/filter/ElemHideEmulationFilter.cpp

Issue 29613616: Issue 6064 - Put C++ code into a configurable namespace (Closed) Base URL: https://github.com/adblockplus/adblockpluscore.git

Patch Set: Fix debug.h to be aligned with assert2 (define vs function) and get rid of a warning in generator.cpp Created Nov. 21, 2017, 2:53 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: compiled/filter/ElemHideEmulationFilter.cpp

diff --git a/compiled/filter/ElemHideEmulationFilter.cpp b/compiled/filter/ElemHideEmulationFilter.cpp

index 4c1c06e7a1043ae5ca91ff23078e5ebd0b55c976..962ca0b3d021f00df0f0dd47af72e810d3cf978b 100644

--- a/compiled/filter/ElemHideEmulationFilter.cpp

+++ b/compiled/filter/ElemHideEmulationFilter.cpp

@@ -17,6 +17,8 @@

#include "ElemHideEmulationFilter.h"

+ABP_NS_USING

hub 2017/11/21 16:48:39 This should be ABP_NS_BEGIN (and have the matching

sergei 2017/11/22 09:39:27 Could you please explain the advantage of wrapping

ElemHideEmulationFilter::ElemHideEmulationFilter(const String& text,

const ElemHideData& data)

: ElemHideBase(Type::ELEMHIDEEMULATION, text, data)