Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(223)

Issue 29613772: Issue 6042 - Introduce ui_warn_tracking boolean preference and updated adbockplusui dependency to... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by saroyanm
Modified:
1 year, 10 months ago
Reviewers:
kzar, Thomas Greiner
Visibility:
Public.

Description

Issue 6042 - Introduced ui_warn_tracking boolean preference and updated adbockplusui dependency to bb9b1b67aedf9

Patch Set 1 : #

Patch Set 2 : Updated the dependency of adblockplusui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/prefs.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8
saroyanm
@greiner maybe you can also give your final go regarding the description as I updated ...
1 year, 11 months ago (2017-11-21 15:27:40 UTC) #1
kzar
LGTM but it might make sense to wait until the adblockplusui changes are ready and ...
1 year, 11 months ago (2017-11-21 15:44:47 UTC) #2
saroyanm
On 2017/11/21 15:44:47, kzar wrote: > LGTM but it might make sense to wait until ...
1 year, 11 months ago (2017-11-21 15:46:52 UTC) #3
Thomas Greiner
On 2017/11/21 15:27:40, saroyanm wrote: > @greiner maybe you can also give your final go ...
1 year, 10 months ago (2017-11-21 17:40:35 UTC) #4
saroyanm
Updated the dependency, will wait for the final go from Dave and push the changes ...
1 year, 10 months ago (2017-11-22 10:48:21 UTC) #5
kzar
On 2017/11/22 10:48:21, saroyanm wrote: > Updated the dependency, will wait for the final go ...
1 year, 10 months ago (2017-11-22 10:55:39 UTC) #6
saroyanm
On 2017/11/22 10:55:39, kzar wrote: > On 2017/11/22 10:48:21, saroyanm wrote: > > Updated the ...
1 year, 10 months ago (2017-11-22 11:35:14 UTC) #7
kzar
1 year, 10 months ago (2017-11-22 11:38:18 UTC) #8
Thanks LGTM, go ahead and push this when you're ready.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5