Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(145)

Issue 29613777: Issue 5817 - Retry sending suggested filters to block element dialog (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by kzar
Modified:
1 year, 10 months ago
Visibility:
Public.

Description

Issue 5817 - Retry sending suggested filters to block element dialog

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebased, addressed Wladimir's feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M _locales/en_US/messages.json View 1 chunk +4 lines, -0 lines 0 comments Download
M composer.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M composer.js View 1 1 chunk +4 lines, -1 line 1 comment Download
M lib/filterComposer.js View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1 I'm not happy about this hack, but as it stands the "block ...
1 year, 10 months ago (2017-11-21 15:39:20 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29613777/diff/29613778/composer.html File composer.html (right): https://codereview.adblockplus.org/29613777/diff/29613778/composer.html#newcode96 composer.html:96: <button id="addButton" class="i18n_add"></button> Shouldn't this button be disabled as ...
1 year, 10 months ago (2017-11-23 11:49:00 UTC) #2
kzar
Patch Set 2 : Rebased, addressed Wladimir's feedback https://codereview.adblockplus.org/29613777/diff/29613778/composer.html File composer.html (right): https://codereview.adblockplus.org/29613777/diff/29613778/composer.html#newcode96 composer.html:96: <button ...
1 year, 10 months ago (2017-11-23 12:31:54 UTC) #3
Wladimir Palant
LGTM
1 year, 10 months ago (2017-11-23 13:50:31 UTC) #4
Thomas Greiner
1 year, 10 months ago (2017-11-23 13:59:36 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5