Issue 5817 - Retry sending suggested filters to block element dialog

lib/filterComposer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 208 matching lines @@
     url: browser.extension.getURL("composer.html"),
     left: 50,
     top: 50,
     width: 420,
     height: 200,
     type: "popup"
   }).then(window =>
   {
     let popupPageId = window.tabs[0].id;
 
+    let doInitAttempt = 0;
     let doInit = () =>
     {
+      doInitAttempt += 1;
+      if (doInitAttempt > 3)
+        return;
+
       browser.tabs.sendMessage(popupPageId, {
         type: "composer.dialog.init",
         sender: sender.page.id,
         filters: message.filters
+      }).catch(e =>
+      {
+        // Firefox 57 sometimes sets the status for a window to "complete"

[Wladimir Palant, 2017/11/23 11:49:00]

Nit: Please drop the version number, we don't know which Firefox versions are
affected.

[kzar, 2017/11/23 12:31:53]

Done.

+        // before it is ready to receive messages[1]. As a workaround we'll
+        // try again a few times with a second delay.
+        // [1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1418655
+        setTimeout(doInit, 1000);

[kzar, 2017/11/21 15:39:20]

Initially I retried every 100ms, but then I found the message was sent seemingly
successfully yet never received. Adding a 1 second delay seemed to work, but of
course this will probably vary depending on the computer.

       });
     };
     if (window.tabs[0].status != "complete")
     {
       let updateListener = (tabId, changeInfo, tab) =>
       {
         if (tabId == popupPageId && changeInfo.status == "complete")
         {
           browser.tabs.onUpdated.removeListener(updateListener);
           doInit();
@@ skipping 47 matching lines @@
 {
   return quoteCSS(message.CSS);
 });
 
 ext.pages.onLoading.addListener(page =>
 {
   // A newly opened tab that is still loading has its URL set to about:blank
   if (/^https?:/.test(page.url.protocol))
     page.sendMessage({type: "composer.content.finished"});
 });