Issue 6034 - :-abp-contains() accept a regular expression

lib/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 /**

[Manish Jethani, 2018/02/21 14:41:59]

I would call this function "textToRegExp" to match "filterToRegExp"

It's just like the latter, but instead of treating its input as an ABP filter it
just treats it as a normal string with no special meaning.

Also then we can rename the parameter from "s" to "text".

The comment could read "Converts raw text into regular expression string", and
basically s/filter/raw/g in the comment.

[hub, 2018/02/21 21:38:00]

Done.

- * Escape string to match to be a regular expression string
- * @param {string} s the string to search for.
- * @return {string} regular expression representation of string match.
+ * Converts raw text into a regular expression string
+ * @param {string} text the string to convert
+ * @return {string} regular expression representation of the text
  */
-function escapeRegExp(s)
+function textToRegExp(text)
 {
-  return s.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&");
+  return text.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&");
 }
 
-exports.escapeRegExp = escapeRegExp;
+exports.textToRegExp = textToRegExp;
 
 /**
  * Converts filter text into regular expression string
  * @param {string} text as in Filter()
  * @return {string} regular expression representation of filter text
  */
 function filterToRegExp(text)
 {
   return text
     // remove multiple wildcards
@@ skipping 53 matching lines @@
         start = i + 1;
       }
     }
   }
 
   selectors.push(selector.substring(start));
   return selectors;
 }
 
 exports.splitSelector = splitSelector;