Issue 29614555: #5020 - Bridge trivial legacy redirects to modern redirect service

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29614555: #5020 - Bridge trivial legacy redirects to modern redirect service (Closed)

Created:
Nov. 21, 2017, 11:17 p.m. by f.nicolaisen

Modified:
Dec. 5, 2017, 10:56 p.m.

Reviewers:
paco, mathias

Base URL:
https://hg1/infrastructure

Visibility:
Public.

Description

#5020 - Bridge trivial legacy redirects to modern redirect service Note that this change requires that it is first deployed to eyeo.to before being deployed to adblockplus.org. We could also consider splitting this into two separate, safer changes. Also note: The changes have not undergone rigurous testing yet! (not so easy to test tho, which could be another argument for splitting it into two separate changes). Finally note that this commit applies cleanly only after https://codereview.adblockplus.org/29613809/ landing first, but it can easily be reworked to apply without it.

Patch Set 1 #

Created: Nov. 21, 2017, 11:17 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -118 lines)			Patch
	M	hiera/roles/web/redirect/eyeo.yaml	View		1 chunk	+29 lines, -0 lines	0 comments	Download
	M	modules/web/templates/adblockplus.org.conf.erb	View		2 chunks	+4 lines, -118 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM.

Expand All Messages | Collapse All Messages