issue 6075 - Hide Acceptable Ads notification when corresponding subscription is removed

desktop-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1100 matching lines @@
       if (subscription.recommended == "privacy")
       {
         privacyList = subscription;
         break;
       }
     }
     return acceptableAdsList && acceptableAdsList.disabled == false &&
       privacyList && privacyList.disabled == false;
   }
 
+  function setPrivacyConflict()
+  {
+    if (hasPrivacyConflict())
+    {
+      getPref("ui_warn_tracking", (showTrackingWarning) =>
+      {
+        E("acceptable-ads").classList.toggle("show-warning", showTrackingWarning);

[Thomas Greiner, 2017/11/23 16:51:30]

Coding style: "Line length: 80 characters or less"

I'd suggest resolving this issue by putting `let warning = E("acceptable-ads");`
at the beginning of the function since we need to call `E("acceptable-ads")` no
matter what so thereby we'd get rid of the duplicated call.

[saroyanm, 2017/11/23 17:01:38]

Agree, we used "acceptableAdsForm" below so I'll use it here as well,
alternatively I can update all instances to "acceptableAdsSection",
"acceptableAdsControl", but both will exceed the limit :/

+      });
+    }
+    else
+    {
+      E("acceptable-ads").classList.remove("show-warning");
+    }
+  }
+
   function populateLists()
   {
     subscriptionsMap = Object.create(null);
     filtersMap = Object.create(null);
 
     // Empty collections and lists
     for (let property in collections)
       collections[property].clearAll();
 
     setCustomFiltersView("empty");
@@ skipping 129 matching lines @@
           knownSubscription.originalTitle = subscription.title;
         else
           knownSubscription[property] = subscription[property];
       }
       subscription = knownSubscription;
     }
     switch (action)
     {
       case "disabled":
         updateSubscription(subscription);
+        setPrivacyConflict();
         break;
       case "downloading":
       case "downloadStatus":
       case "homepage":
       case "lastDownload":
       case "title":
         updateSubscription(subscription);
         break;
       case "added":
         let {url, recommended} = subscription;
         // Handle custom subscription
         if (/^~user/.test(url))
         {
           loadCustomFilters(subscription.filters);
           return;
         }
         else if (url in subscriptionsMap)
           updateSubscription(subscription);
         else
           addSubscription(subscription);
 
         if (isAcceptableAds(url))
           setAcceptableAds();
 
-        if ((url == acceptableAdsUrl || recommended == "privacy") &&
-          hasPrivacyConflict())
-        {
-          getPref("ui_warn_tracking", (showTrackingWarning) =>
-          {
-            if (showTrackingWarning)
-              E("acceptable-ads").classList.add("show-warning");
-          });
-        }
-
         collections.filterLists.addItem(subscription);
+        setPrivacyConflict();
         break;
       case "removed":
         if (subscription.recommended)
         {
           subscription.disabled = true;
           onSubscriptionMessage("disabled", subscription);
         }
         else
         {
           delete subscriptionsMap[subscription.url];
           if (isAcceptableAds(subscription.url))
           {
             setAcceptableAds();
           }
           else
           {
             collections.more.removeItem(subscription);
           }
         }
+
         collections.filterLists.removeItem(subscription);
+        setPrivacyConflict();
         break;
     }
   }
 
   function hidePref(key, value)
   {
     let element = document.querySelector("[data-pref='" + key + "']");
     if (element)
       element.setAttribute("aria-hidden", value);
   }
@@ skipping 34 matching lines @@
     switch (key)
     {
       case "notifications_ignoredcategories":
         value = value.indexOf("*") == -1;
         break;
 
       case "notifications_showui":
         hidePref("notifications_ignoredcategories", !value);
         break;
       case "ui_warn_tracking":
-        let showWarning = (value && hasPrivacyConflict());
-        E("acceptable-ads").classList.toggle("show-warning", showWarning);
+        setPrivacyConflict();
         break;
     }
 
     let checkbox = document.querySelector(
       "[data-pref='" + key + "'] button[role='checkbox']"
     );
     if (checkbox)
       checkbox.setAttribute("aria-checked", value);
   }
 
@@ skipping 67 matching lines @@
   });
   browser.runtime.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
              "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 }