issue 6075 - Hide Acceptable Ads notification when corresponding subscription is removed

desktop-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1102 matching lines @@
         privacyList = subscription;
         break;
       }
     }
     return acceptableAdsList && acceptableAdsList.disabled == false &&
       privacyList && privacyList.disabled == false;
   }
 
   function setPrivacyConflict()
   {
+    let acceptableAdsForm = E("acceptable-ads");
     if (hasPrivacyConflict())
     {
       getPref("ui_warn_tracking", (showTrackingWarning) =>
       {
-        E("acceptable-ads").classList.toggle("show-warning", showTrackingWarning);

[Thomas Greiner, 2017/11/23 16:51:30]

Coding style: "Line length: 80 characters or less"

I'd suggest resolving this issue by putting `let warning = E("acceptable-ads");`
at the beginning of the function since we need to call `E("acceptable-ads")` no
matter what so thereby we'd get rid of the duplicated call.

[saroyanm, 2017/11/23 17:01:38]

Agree, we used "acceptableAdsForm" below so I'll use it here as well,
alternatively I can update all instances to "acceptableAdsSection",
"acceptableAdsControl", but both will exceed the limit :/

+        acceptableAdsForm.classList.toggle("show-warning", showTrackingWarning);
       });
     }
     else
     {
-      E("acceptable-ads").classList.remove("show-warning");
+      acceptableAdsForm.classList.remove("show-warning");
     }
   }
 
   function populateLists()
   {
     subscriptionsMap = Object.create(null);
     filtersMap = Object.create(null);
 
     // Empty collections and lists
     for (let property in collections)
@@ skipping 323 matching lines @@
   });
   browser.runtime.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
              "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 }