Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29615651: Rename adblockplus host to match production environment (Closed)

Created:
Nov. 22, 2017, 4:55 p.m. by f.lopez
Modified:
Nov. 27, 2017, 3:26 p.m.
Reviewers:
mathias, f.nicolaisen
Visibility:
Public.

Description

Rename adblockplus host to match production environment

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/private-stub/hiera/hosts.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
f.lopez
Nov. 22, 2017, 4:55 p.m. (2017-11-22 16:55:29 UTC) #1
f.nicolaisen
On 2017/11/22 16:55:29, f.lopez wrote: Aren't there many more like this, like eyeo-to-1/redirect-1? I thought ...
Nov. 22, 2017, 5:03 p.m. (2017-11-22 17:03:34 UTC) #2
f.lopez
On 2017/11/22 17:03:34, f.nicolaisen wrote: > On 2017/11/22 16:55:29, f.lopez wrote: > > Aren't there ...
Nov. 22, 2017, 6:34 p.m. (2017-11-22 18:34:03 UTC) #3
mathias
LGTM. Note that there is no requirement to have the development hosts be of similar ...
Nov. 23, 2017, 3:27 p.m. (2017-11-23 15:27:43 UTC) #4
f.nicolaisen
Nov. 23, 2017, 3:30 p.m. (2017-11-23 15:30:17 UTC) #5
On 2017/11/23 15:27:43, mathias wrote:
> LGTM. Note that there is no requirement to have the development hosts be of
> similar or same name than the production ones. In fact it does not matter
much,
> except for a very few hard-coded pieces maybe.

LGTM. Good point.

Powered by Google App Engine
This is Rietveld