Issue 29615654: Issue 6062 - Additional adjustments to the option page style changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29615654: Issue 6062 - Additional adjustments to the option page style changes (Closed)

Created:
Nov. 22, 2017, 8:08 p.m. by saroyanm

Modified:
Nov. 24, 2017, 11:34 a.m.

Reviewers:
martin, ire

CC:
Thomas Greiner

Visibility:
Public.

Description

Issue 6062 - Additional adjustments to the option page style changes

Patch Set 1 #

Created: Nov. 22, 2017, 8:09 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -40 lines)			Patch
M	skin/desktop-options.css	View	10 chunks	+15 lines, -19 lines	0 comments	Download
M	skin/icons/code.svg	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	skin/icons/delete.svg	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skin/icons/gear.svg	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skin/icons/globe.svg	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skin/icons/reload.svg	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skin/icons/tooltip.svg	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	skin/icons/trash.svg	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	skin/social/facebook.svg	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skin/social/googleplus.svg	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	skin/social/twitter.svg	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

saroyanm

This changes do not contain "Bonus" fixes (I need to investigate them). I'll provide "Bonus" ...

Nov. 22, 2017, 8:15 p.m. (2017-11-22 20:15:31 UTC) #1

martin

Nov. 24, 2017, 11:14 a.m. (2017-11-24 11:14:54 UTC) #2

On 2017/11/22 20:15:31, saroyanm wrote:
> This changes do not contain "Bonus" fixes (I need to investigate them).
> I'll provide "Bonus" fixes as additional patch to current review, or as a
> separate review, depending on how fast this change will be resolved.
> 
> @Ire is on vacation, Martin and Thomas I'm adding you to the CC in order if
> anybody from you will have time to review the changes feel free to jump and do
> it, otherwise we will need to wait for Ire.
> 
> Note: Changes are small and should be easy to resolve.

Mostly stylistic changes, modifying existing values. LGTM.

Expand All Messages | Collapse All Messages