Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(400)

Issue 29615667: Issue 6069 - Add documentation for :-abp-contains() selector (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by hub
Modified:
2 years, 4 months ago
Base URL:
https://hg.adblockplus.org/web.adblockplus.org/
Visibility:
Public.

Description

Issue 6069 - Add documentation for :-abp-contains() selector

Patch Set 1 #

Patch Set 2 : Fix a markup error #

Total comments: 4

Patch Set 3 : Lisa's edits #

Total comments: 2

Patch Set 4 : fix nit #

Patch Set 5 : Use the proper dash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M pages/filter-cheatsheet.html View 1 2 chunks +9 lines, -1 line 0 comments Download
M pages/filters.html View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 21
hub
2 years, 4 months ago (2017-11-22 21:28:54 UTC) #1
juliandoucette
The HTML LGTM. @Lisa will you double check the content. @Tamara will you put this ...
2 years, 4 months ago (2017-11-22 21:56:12 UTC) #2
tamara
On 2017/11/22 21:56:12, juliandoucette wrote: > The HTML LGTM. > > @Lisa will you double ...
2 years, 4 months ago (2017-11-23 09:40:58 UTC) #3
Lisa
On 2017/11/23 09:40:58, tamara wrote: > On 2017/11/22 21:56:12, juliandoucette wrote: > > The HTML ...
2 years, 4 months ago (2017-11-27 00:18:53 UTC) #4
juliandoucette
On 2017/11/27 00:18:53, Lisa wrote: > Hi Julian...do you have a deadline for this? Content ...
2 years, 4 months ago (2017-11-27 17:05:58 UTC) #5
tamara
On 2017/11/27 17:05:58, juliandoucette wrote: > On 2017/11/27 00:18:53, Lisa wrote: > > Hi Julian...do ...
2 years, 4 months ago (2017-11-27 17:47:27 UTC) #6
juliandoucette
On 2017/11/27 17:47:27, tamara wrote: Cool, we'll push English and re-translate the entire page later ...
2 years, 4 months ago (2017-11-27 18:05:51 UTC) #7
juliandoucette
Removed Tamara from Reviewers.
2 years, 4 months ago (2017-11-27 18:06:37 UTC) #8
Lisa
Made a few grammatical edits. To answer your question - yes, the content team should ...
2 years, 4 months ago (2017-11-27 18:32:11 UTC) #9
hub
https://codereview.adblockplus.org/29615667/diff/29615671/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29615667/diff/29615671/pages/filters.html#newcode240 pages/filters.html:240: {{ elemhide-emulation-1 Sometimes the standard CSS selectors aren't powerful ...
2 years, 4 months ago (2017-11-28 19:23:27 UTC) #10
juliandoucette
LGTM after NIT below. https://codereview.adblockplus.org/29615667/diff/29622614/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29615667/diff/29622614/pages/filters.html#newcode261 pages/filters.html:261: {{ abp-contains-1 <code><fix>:-abp-contains(text)</fix></code> will select ...
2 years, 4 months ago (2017-11-29 20:32:17 UTC) #11
hub
https://codereview.adblockplus.org/29615667/diff/29622614/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29615667/diff/29622614/pages/filters.html#newcode261 pages/filters.html:261: {{ abp-contains-1 <code><fix>:-abp-contains(text)</fix></code> will select elements based on their ...
2 years, 4 months ago (2017-11-29 22:35:55 UTC) #12
juliandoucette
On 2017/11/29 22:35:55, hub wrote: > it was my understanding that &mdash; was the proper ...
2 years, 4 months ago (2017-11-29 23:52:33 UTC) #13
Lisa
On 2017/11/29 23:52:33, juliandoucette wrote: > On 2017/11/29 22:35:55, hub wrote: > > it was ...
2 years, 4 months ago (2017-11-30 00:50:31 UTC) #14
juliandoucette
On 2017/11/30 00:50:31, Lisa wrote: > I'm not clear on why we have to keep ...
2 years, 4 months ago (2017-11-30 01:25:18 UTC) #15
Lisa
On 2017/11/30 01:25:18, juliandoucette wrote: > On 2017/11/30 00:50:31, Lisa wrote: > > I'm not ...
2 years, 4 months ago (2017-11-30 01:38:30 UTC) #16
juliandoucette
On 2017/11/30 01:25:18, juliandoucette wrote: > [browser, font, cms] support (I just looked into it). ...
2 years, 4 months ago (2017-11-30 01:41:55 UTC) #17
juliandoucette
CC Ire @Ire please review my last 3 replies [in case I'm wrong, in order ...
2 years, 4 months ago (2017-11-30 01:46:12 UTC) #18
ire
On 2017/11/30 01:46:12, juliandoucette wrote: > CC Ire > > @Ire please review my last ...
2 years, 4 months ago (2017-11-30 13:15:55 UTC) #19
hub
On 2017/11/30 13:15:55, ire wrote: > Seen. Your last answer is correct from what I ...
2 years, 4 months ago (2017-11-30 19:29:29 UTC) #20
juliandoucette
2 years, 4 months ago (2017-12-01 15:22:15 UTC) #21
On 2017/11/30 19:29:29, hub wrote:
> Done. updated patch.

Thanks hub. Will you email me your commit so that I can push it for you?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5