Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29616589: Noissue - Ensure ElemHideBase::GetSelector() doesn't misuse a read only string (Closed)

Created:
Nov. 23, 2017, 4:50 p.m. by hub
Modified:
Nov. 28, 2017, 1:02 p.m.
Reviewers:
sergei, Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Ensure ElemHideBase::GetSelector() doesn't misuse a read only string

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M compiled/filter/ElemHideBase.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
hub
Nov. 23, 2017, 4:50 p.m. (2017-11-23 16:50:37 UTC) #1
hub
This is a followup to Issue 5174. To notice it, you need to had sergei ...
Nov. 23, 2017, 4:54 p.m. (2017-11-23 16:54:50 UTC) #2
hub
If you apply https://codereview.adblockplus.org/29616611/ you'll see the error when running the tests.
Nov. 24, 2017, 8:29 p.m. (2017-11-24 20:29:03 UTC) #3
sergei
LGTM
Nov. 24, 2017, 8:34 p.m. (2017-11-24 20:34:18 UTC) #4
Wladimir Palant
Nov. 28, 2017, 1:02 p.m. (2017-11-28 13:02:19 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld