Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29616607: Issue 5972 - Fix options page title (Closed)

Created:
Nov. 23, 2017, 7:11 p.m. by saroyanm
Modified:
Nov. 23, 2017, 7:39 p.m.
Reviewers:
martin, Thomas Greiner, kzar
CC:
tamara
Base URL:
https://hg.adblockplus.org/adblockplusui
Visibility:
Public.

Description

Issue 5972 - Fix options page title

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M desktop-options.html View 1 chunk +1 line, -1 line 2 comments Download
M locale/en_US/desktop-options.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
saroyanm
If anyone will have time to do a review, please do it, it's just a ...
Nov. 23, 2017, 7:14 p.m. (2017-11-23 19:14:14 UTC) #1
kzar
(Copying Tamara in, since I guess the adblockplusui Crowdin project will need to be updated ...
Nov. 23, 2017, 7:19 p.m. (2017-11-23 19:19:53 UTC) #2
saroyanm
https://codereview.adblockplus.org/29616607/diff/29616608/desktop-options.html File desktop-options.html (right): https://codereview.adblockplus.org/29616607/diff/29616608/desktop-options.html#newcode41 desktop-options.html:41: <p class="i18n_options_page_title"></p> On 2017/11/23 19:19:53, kzar wrote: > What ...
Nov. 23, 2017, 7:26 p.m. (2017-11-23 19:26:26 UTC) #3
kzar
Nov. 23, 2017, 7:28 p.m. (2017-11-23 19:28:29 UTC) #4
Cool OK, LGTM

Powered by Google App Engine
This is Rietveld