Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 29621569: Issue 6050 - Use localStorage for blocked_total preference on Gecko (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by kzar
Modified:
1 year, 9 months ago
Reviewers:
Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 6050 - Use localStorage for blocked_total preference on Gecko

Patch Set 1 #

Patch Set 2 : Use parseInt instead of JSON.parse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M lib/prefs.js View 1 2 chunks +23 lines, -24 lines 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1 I figure this is good enough for now, what do you guys ...
1 year, 9 months ago (2017-11-27 18:25:49 UTC) #1
kzar
Patch Set 2 : Use parseInt instead of JSON.parse
1 year, 9 months ago (2017-11-27 18:51:36 UTC) #2
Wladimir Palant
1 year, 9 months ago (2017-11-28 11:34:26 UTC) #3
As discussed on IRC, I don't consider this hack worth doing. If
window.localStorage doesn't survive clearing private data, then maybe we should
use IndexedDB for preferences - assuming that it doesn't exhibit the same
behavior.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5