Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(144)

Issue 29622565: Issue 6041 - Navbar search field moves after navbar logo is downloaded (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by ire
Modified:
1 year, 9 months ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 6041 - Navbar search field moves after navbar logo is downloaded

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M includes/layout/header.tmpl View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 3
ire
1 year, 9 months ago (2017-11-28 09:06:20 UTC) #1
juliandoucette
LGTM (See NIT and create issue if necessary). https://codereview.adblockplus.org/29622565/diff/29622566/includes/layout/header.tmpl File includes/layout/header.tmpl (right): https://codereview.adblockplus.org/29622565/diff/29622566/includes/layout/header.tmpl#newcode14 includes/layout/header.tmpl:14: <img ...
1 year, 9 months ago (2017-11-28 14:55:16 UTC) #2
ire
1 year, 9 months ago (2017-11-28 16:13:49 UTC) #3
https://codereview.adblockplus.org/29622565/diff/29622566/includes/layout/hea...
File includes/layout/header.tmpl (right):

https://codereview.adblockplus.org/29622565/diff/29622566/includes/layout/hea...
includes/layout/header.tmpl:14: <img src="/img/png/eyeo-help.png"
srcset="/img/svg/eyeo-help.svg 2x" alt="{{ "eyeo Help" | translate("site-title",
"Image alt text") }}" height="30" width="205">
On 2017/11/28 14:55:16, juliandoucette wrote:
> NIT: I think that you could use em inside of your CSS file instead. But it
seems
> you measured your navbar/header heights in px inside SCSS - so perhaps this
> belongs to a low priority list of things you can refactor?

Wasn't the point to put these values in HTML? AFAIK that is the only way to make
sure the browser reserves the amount of space needed, i.e. not if it's defined
in CSS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5