Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: includes/layout/header.tmpl

Issue 29622565: Issue 6041 - Navbar search field moves after navbar logo is downloaded (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Nov. 28, 2017, 9:06 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% if product_id %} 1 {% if product_id %}
2 {% set product = products[product_id] %} 2 {% set product = products[product_id] %}
3 {% set search_label = "Search " + product.full_name + " Help" %} 3 {% set search_label = "Search " + product.full_name + " Help" %}
4 {% set search_site = config.get("general", "siteurl") + "," + product.url %} 4 {% set search_site = config.get("general", "siteurl") + "," + product.url %}
5 {% else %} 5 {% else %}
6 {% set search_label = "Search for help..." %} 6 {% set search_label = "Search for help..." %}
7 {% set search_site = config.get("general", "siteurl") %} 7 {% set search_site = config.get("general", "siteurl") %}
8 {% endif %} 8 {% endif %}
9 9
10 <header id="site-header" class="navbar {{ 'site-header-minimal' if product_id is not defined }}"> 10 <header id="site-header" class="navbar {{ 'site-header-minimal' if product_id is not defined }}">
11 <div class="container large-desktop-width"> 11 <div class="container large-desktop-width">
12 <h1 id="site-title"> 12 <h1 id="site-title">
13 {{ "index" | linkify() }} 13 {{ "index" | linkify() }}
14 <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt ="{{ "eyeo Help" | translate("site-title", "Image alt text") }}"> 14 <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt ="{{ "eyeo Help" | translate("site-title", "Image alt text") }}" height="30" wid th="205">
juliandoucette 2017/11/28 14:55:16 NIT: I think that you could use em inside of your
ire 2017/11/28 16:13:49 Wasn't the point to put these values in HTML? AFAI
15 </a> 15 </a>
16 </h1> 16 </h1>
17 17
18 <button class="toggle-navbar-collapse unstyled phablet-and-mobile-only"> 18 <button class="toggle-navbar-collapse unstyled phablet-and-mobile-only">
19 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2x" a lt="{{ "Toggle Search Bar" | translate("search-toggle-alt", "Image alt text") }} "> 19 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2x" a lt="{{ "Toggle Search Bar" | translate("search-toggle-alt", "Image alt text") }} ">
20 </button> 20 </button>
21 21
22 <div class="navbar-collapse"> 22 <div class="navbar-collapse">
23 <form id="search-form" action="https://duckduckgo.com" method="GET"> 23 <form id="search-form" action="https://duckduckgo.com" method="GET">
24 <label for="search" class="sr-only">{{ search_label | translate("search- form-label", "Input label") }}</label> 24 <label for="search" class="sr-only">{{ search_label | translate("search- form-label", "Input label") }}</label>
25 <input id="search" name="q" type="search" placeholder="{{ search_label | translate("search-form-label", "Input label") }}"> 25 <input id="search" name="q" type="search" placeholder="{{ search_label | translate("search-form-label", "Input label") }}">
26 <input type="hidden" name="sites" value="{{ search_site }}"> 26 <input type="hidden" name="sites" value="{{ search_site }}">
27 <button type="submit"> 27 <button type="submit">
28 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2 x" alt="{{ "Search" | translate("search-icon-alt", "Image alt text") }}"> 28 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2 x" alt="{{ "Search" | translate("search-icon-alt", "Image alt text") }}">
29 </button> 29 </button>
30 </form> 30 </form>
31 31
32 {% if product_id %} 32 {% if product_id %}
33 <nav id="product-website-link"> 33 <nav id="product-website-link">
34 <a href="{{ product.url }}"> 34 <a href="{{ product.url }}">
35 {{ product.full_name | translate(product_id+"-product-link", "Link lab el") }}<img src="/img/png/external-icon.png" srcset="/img/svg/external-icon.svg 2x" alt="{{ "External link icon" | translate("external-link-icon", "Image alt te xt") }}"> 35 {{ product.full_name | translate(product_id+"-product-link", "Link lab el") }}<img src="/img/png/external-icon.png" srcset="/img/svg/external-icon.svg 2x" alt="{{ "External link icon" | translate("external-link-icon", "Image alt te xt") }}">
36 </a> 36 </a>
37 </nav> 37 </nav>
38 {% endif %} 38 {% endif %}
39 </div> 39 </div>
40 </div> 40 </div>
41 </header> 41 </header>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld