Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/meta/standard.tmpl

Issue 29622568: Issue 6013 - Add site name to document title in website-defaults standard metadata (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Created Nov. 28, 2017, 9:11 a.m.
Right Patch Set: Use get_string to get site name Created Dec. 4, 2017, 9:09 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | locales/en/site.json » ('j') | locales/en/site.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <meta charset="utf-8"> 1 <meta charset="utf-8">
2 <meta http-equiv="x-ua-compatible" content="ie=edge"> 2 <meta http-equiv="x-ua-compatible" content="ie=edge">
3 <meta name="viewport" content="width=device-width, initial-scale=1"> 3 <meta name="viewport" content="width=device-width, initial-scale=1">
4 4
5 {% if page == "index" or config.get("general", "sitename") is not defined %} 5 {% if title_exclude_sitename or not has_string("name", "site") %}
ire 2017/11/28 09:12:49 This currently doesn't work because if I try "conf
juliandoucette 2017/11/28 14:49:21 I don't think that the index page will be the only
juliandoucette 2017/11/28 14:49:21 I think that this is how to find the answer to you
ire 2017/11/28 16:11:26 Alright, thanks!
ire 2017/11/28 16:11:26 Acknowledged.
6 <title>{{ title | translate("page-title", "Page title") }}</title> 6 <title>{{ title | translate("page-title", "Page title") }}</title>
7 {% else %} 7 {% else %}
8 <title>{{ title | translate("page-title", "Page title") }} | {{ config.get("gene ral", "sitename") }}</title> 8 <title>{{ title | translate("page-title", "Page title") }} | {{ get_string("name ", "site") }}</title>
9 {% endif %} 9 {% endif %}
10 10
11 {% if description %} 11 {% if description %}
12 <meta name="description" content="{{ description | translate("page-description ", "Page description") }}"> 12 <meta name="description" content="{{ description | translate("page-description ", "Page description") }}">
13 {% endif %} 13 {% endif %}
14 <link rel="canonical" href="{{ get_canonical_url(page) }}"> 14 <link rel="canonical" href="{{ get_canonical_url(page) }}">
LEFTRIGHT

Powered by Google App Engine
This is Rietveld