settings.ini - Issue 29622568: Issue 6013 - Add site name to document title in website-defaults standard metadata

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: settings.ini

Issue 29622568: Issue 6013 - Add site name to document title in website-defaults standard metadata (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Use config.has_option, use title_exclude_sitename Created Nov. 28, 2017, 4:28 p.m.

Right Patch Set: Use get_string to get site name Created Dec. 4, 2017, 9:09 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 siteurl = http://localhost	2 siteurl = http://localhost

3 sitename = eyeo Website Defaults

4 defaultlocale = en	3 defaultlocale = en

5 defaultpage = index	4 defaultpage = index

6	5
	juliandoucette 2017/12/04 10:33:08 Did you mean to add a sitename? Did you mean to add a sitename? ire 2017/12/04 10:41:09 Is that still needed if we're not using it from th Show quoted text On 2017/12/04 10:33:08, juliandoucette wrote: > Did you mean to add a sitename? Is that still needed if we're not using it from this config? juliandoucette 2017/12/04 10:50:51 No ( oops :D ) Show quoted text On 2017/12/04 10:41:09, ire wrote: > On 2017/12/04 10:33:08, juliandoucette wrote: > > Did you mean to add a sitename? > > Is that still needed if we're not using it from this config? No ( oops :D )
7 [langnames]	6 [langnames]

8 en = English	7 en = English

LEFT	RIGHT