Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(409)

Issue 29622588: Issue 6103 - Use new buildtools.build interface and fixed uncommited changes warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by saroyanm
Modified:
2 years, 2 months ago
Reviewers:
tlucas
CC:
Thomas Greiner, kzar
Base URL:
https://hg.adblockplus.org/adblockplusui
Visibility:
Public.

Description

Issue 6103 - Use new buildtools.build interface and fixed uncommited changes warning

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M build.py View 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 3 chunks +23 lines, -2 lines 1 comment Download

Messages

Total messages: 2
saroyanm
@tlucas can you please have a look. https://codereview.adblockplus.org/29622588/diff/29622589/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29622588/diff/29622589/ensure_dependencies.py#newcode47 ensure_dependencies.py:47: NPM_LOCKFILE = ...
2 years, 2 months ago (2017-11-28 14:49:15 UTC) #1
tlucas
2 years, 2 months ago (2017-11-28 14:59:11 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5