Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(792)

Issue 29624561: Issue 6104 - Minified code in help center repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by ire
Modified:
3 days, 1 hour ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 6104 - Minified code in help center repository

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fix sourcemaps for CSS files, Change tabs to spaces #

Patch Set 3 : Separate static directory into src and dist #

Patch Set 4 : Move all requires to top of gulpfile.js #

Total comments: 12

Patch Set 5 : Consolidate gulp tasks #

Patch Set 6 : Consolidate gulp tasks #

Patch Set 7 : Consolidated gulp tasks #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+1531 lines, -708 lines) Patch
M .gitignore View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M .hgignore View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M globals/get_inline_bg.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gulpfile.js View 1 2 3 4 1 chunk +42 lines, -7 lines 6 comments Download
M includes/layout/header.tmpl View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M includes/product-topics-accordion.tmpl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M package.json View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M static/dist/fonts/Source-Sans-Pro-400/LICENSE.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.eot View 1 2 Binary file 0 comments Download
M static/dist/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.ttf View 1 2 Binary file 0 comments Download
M static/dist/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.woff View 1 2 Binary file 0 comments Download
M static/dist/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.woff2 View 1 2 Binary file 0 comments Download
M static/dist/fonts/Source-Sans-Pro-600/LICENSE.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.eot View 1 2 Binary file 0 comments Download
M static/dist/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.ttf View 1 2 Binary file 0 comments Download
M static/dist/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.woff View 1 2 Binary file 0 comments Download
M static/dist/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.woff2 View 1 2 Binary file 0 comments Download
M static/dist/img/png/accent-bg.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/arrow-icon-down-secondary.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/arrow-icon-left-gray.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/arrow-icon-right-gray.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/arrow-icon-secondary.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/chrome.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/email-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/external-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/eyeo-help.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/firefox.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/help-bg.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/install-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/ios.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/logo-abp.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/logo-facebook.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/logo-twitter.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/maxthon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/mobile-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/msedge.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/msie.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/opera.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/popular-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/reporting-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/safari.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/samsungBrowser.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/search-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/settings-icon.png View 1 2 Binary file 0 comments Download
M static/dist/img/png/yandexbrowser.png View 1 2 Binary file 0 comments Download
M static/dist/img/svg/arrow-icon-down-secondary.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/arrow-icon-secondary.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/chrome.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/email-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/external-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/eyeo-help.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/firefox.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/install-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/ios.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/logo-abp.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/logo-facebook.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/logo-twitter.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/maxthon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/mobile-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/msedge.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/msie.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/opera.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/popular-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/reporting-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/safari.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/samsungBrowser.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/search-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/settings-icon.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/dist/img/svg/yandexbrowser.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/js/main.js View 1 2 1 chunk +0 lines, -356 lines 0 comments Download
M static/js/vendor/classList.min.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M static/js/vendor/element-closest.min.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M static/js/vendor/html5shiv.min.js View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M static/js/vendor/ie8.min.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M static/js/vendor/respond.min.js View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
R static/scss/components/_breadcrumb.scss View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
R static/scss/components/_select.scss View 1 2 1 chunk +0 lines, -171 lines 0 comments Download
R static/scss/layout/_body.scss View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
R static/scss/main.scss View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
A static/src/js/main.js View 1 2 1 chunk +378 lines, -0 lines 0 comments Download
M static/src/js/vendor/bowser.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A static/src/js/vendor/classList.js View 1 2 1 chunk +263 lines, -0 lines 0 comments Download
A static/src/js/vendor/element-closest.js View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A static/src/js/vendor/html5shiv.js View 1 2 1 chunk +327 lines, -0 lines 0 comments Download
A static/src/js/vendor/ie8.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A static/src/js/vendor/respond.js View 1 2 1 chunk +149 lines, -0 lines 0 comments Download
M static/src/scss/_licence.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/base/_font.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/base/_utilities.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/base/_variables.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/components/_accordion.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/components/_article.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A static/src/scss/components/_breadcrumb.scss View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
M static/src/scss/components/_browser-select.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/components/_card.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/components/_contact.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/components/_lists.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/components/_pre-icon.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/components/_search-form.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A static/src/scss/components/_select.scss View 1 2 1 chunk +171 lines, -0 lines 0 comments Download
M static/src/scss/content/_typography.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A static/src/scss/layout/_body.scss View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M static/src/scss/layout/_footer.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/layout/_grid.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/layout/_header.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/scss/layout/_navbar.scss View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A static/src/scss/main.scss View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
M templates/article.tmpl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M templates/minimal.tmpl View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12
ire
2 weeks, 1 day ago (2017-11-29 14:25:33 UTC) #1
ire
Here's my first crack at this. A couple things to note: - Since there were ...
2 weeks, 1 day ago (2017-11-29 14:30:00 UTC) #2
juliandoucette
> Since there were so many files, I didn't think it made sense to have ...
2 weeks ago (2017-11-29 23:30:36 UTC) #3
ire
New patchset uploaded On 2017/11/29 23:30:36, juliandoucette wrote: > > Since there were so many ...
2 weeks ago (2017-11-30 10:04:43 UTC) #4
juliandoucette
> Good point. What do you think of separating the `static` folder into two: `dist` ...
1 week, 6 days ago (2017-12-01 15:53:26 UTC) #5
ire
On 2017/12/01 15:53:26, juliandoucette wrote: > Detail: You haven't implemented the src/dist directory structure in ...
1 week, 3 days ago (2017-12-04 08:41:03 UTC) #6
juliandoucette
I checked with kzar and palant in #adblockplus (they responded this morning if you want ...
1 week, 3 days ago (2017-12-04 10:49:38 UTC) #7
ire
On 2017/12/04 10:49:38, juliandoucette wrote: > I checked with kzar and palant in #adblockplus (they ...
1 week, 3 days ago (2017-12-04 14:20:03 UTC) #8
juliandoucette
I only reviewed the gulpfile. https://codereview.adblockplus.org/29624561/diff/29629921/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29624561/diff/29629921/.gitignore#newcode2 .gitignore:2: static/dist/css (Commented here because ...
1 week, 1 day ago (2017-12-06 15:01:38 UTC) #9
ire
https://codereview.adblockplus.org/29624561/diff/29629921/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29624561/diff/29629921/.gitignore#newcode2 .gitignore:2: static/dist/css On 2017/12/06 15:01:34, juliandoucette wrote: > (Commented here ...
1 week ago (2017-12-07 14:54:25 UTC) #10
juliandoucette
LGTM + NITs https://codereview.adblockplus.org/29624561/diff/29632976/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29624561/diff/29632976/gulpfile.js#newcode33 gulpfile.js:33: gulp.task('css', function() { Single quotes :( ...
6 days, 2 hours ago (2017-12-08 14:57:24 UTC) #11
ire
3 days, 1 hour ago (2017-12-11 15:29:34 UTC) #12
Message was sent while issue was closed.
https://codereview.adblockplus.org/29624561/diff/29632976/gulpfile.js
File gulpfile.js (right):

https://codereview.adblockplus.org/29624561/diff/29632976/gulpfile.js#newcode33
gulpfile.js:33: gulp.task('css', function() {
On 2017/12/08 14:57:21, juliandoucette wrote:
> Single quotes :( ...
> 
> (I love single quotes... I want to use them someday... But... You know.)

Done.

https://codereview.adblockplus.org/29624561/diff/29632976/gulpfile.js#newcode34
gulpfile.js:34: return gulp.src(`./static/src/scss/main.scss`)
On 2017/12/08 14:57:17, juliandoucette wrote:
> Backtics...

Done.

https://codereview.adblockplus.org/29624561/diff/29632976/gulpfile.js#newcode52
gulpfile.js:52: ext: {src:'.js', min:'.min.js'},
On 2017/12/08 14:57:17, juliandoucette wrote:
> Maybe src:js is unnecessary? 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5