Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29626555: Fixes #6109 - Install SwiftLint Script to project (Closed)

Created:
Dec. 1, 2017, 9:03 a.m. by a.shephard
Modified:
Dec. 4, 2017, 3:22 p.m.
Reviewers:
d108, dean
Visibility:
Public.

Description

Fixes #6109 - Install SwiftLint Script to project

Patch Set 1 #

Patch Set 2 : Fixes #6109 - Install SwiftLint Script to project #

Patch Set 3 : Fixes #6109 - Install SwiftLint script to project #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A .swiftlint.yml View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M AdblockBrowser.xcodeproj/project.pbxproj View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8
a.shephard
Dec. 1, 2017, 9:04 a.m. (2017-12-01 09:04:28 UTC) #1
dean
On 2017/12/01 09:04:28, a.shephard wrote: LGTM
Dec. 1, 2017, 9:26 a.m. (2017-12-01 09:26:52 UTC) #2
d108
To match our current usage of swiftlint, the shell script should match what was used ...
Dec. 1, 2017, 11 a.m. (2017-12-01 11:00:50 UTC) #3
dean
On 2017/12/01 11:00:50, d108 wrote: > To match our current usage of swiftlint, the shell ...
Dec. 1, 2017, 11:14 a.m. (2017-12-01 11:14:28 UTC) #4
a.shephard
updated with the script from ABP project.
Dec. 1, 2017, noon (2017-12-01 12:00:57 UTC) #5
dean
On 2017/12/01 12:00:57, a.shephard wrote: > updated with the script from ABP project. lgtm
Dec. 1, 2017, 12:22 p.m. (2017-12-01 12:22:32 UTC) #6
d108
LGTM
Dec. 1, 2017, 2:14 p.m. (2017-12-01 14:14:14 UTC) #7
dean
Dec. 4, 2017, 11:30 a.m. (2017-12-04 11:30:47 UTC) #8
On 2017/12/01 14:14:14, d108 wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld