Issue 6061 - Added important to utilities

static/scss/_utilities.scss

 // This file is part of website-defaults
 // Copyright (C) 2016-present eyeo GmbH
 //
 // website-defaults is free software: you can redistribute it and/or
 // modify it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // website-defaults is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with website-defaults.  If not, see <http://www.gnu.org/licenses/>.
 
 /*******************************************************************************
  * Utilities
  ******************************************************************************/
 
 /* Responsive widths
  ******************************************************************************/
 
 /**
  * Stretch content (e.g. images) full-width
  */
 .full-width
 {
-  display: block !important;
-  width: 100% !important;
+  display: block;
+  width: 100%;
 }
 
 /**
  * Center content within a (responsive) fixed width
  */
 .container
 {
-  width: $container-width !important;
-  max-width: 100% !important;
-  margin-right: auto !important;
-  margin-left: auto !important;
-  padding-right: $small-space !important;
-  padding-left: $small-space !important;
+  width: $container-width;
+  max-width: 100%;
+  margin-right: auto;
+  margin-left: auto;
+  padding-right: $small-space;
+  padding-left: $small-space;
 }
 
 /* Device widths
  ******************************************************************************/
 
-.phone-width { width: $phone-width !important; }
-.phablet-width { width: $phablet-width !important; }
-.tablet-width { width: $tablet-width !important; }
-.desktop-width { width: $desktop-width !important; }
-.large-desktop-width { width: $large-desktop-width !important; }
+.phone-width { width: $phone-width; }
+.phablet-width { width: $phablet-width; }
+.tablet-width { width: $tablet-width; }
+.desktop-width { width: $desktop-width; }
+.large-desktop-width { width: $large-desktop-width; }
 
 /* Text alignment
  ******************************************************************************/
 
-.text-center { text-align: center !important; }
-.text-left { text-align: left !important; }
-.text-right { text-align: right !important; }
-.text-start { text-align: left !important; }
-[dir="rtl"] .text-start { text-align: right !important; }
-.text-end { text-align: right !important; }
-[dir="rtl"] .text-end { text-align: left !important; }
+.text-center { text-align: center; }
+.text-left { text-align: left; }
+.text-right { text-align: right; }
+.text-start { text-align: left; }
+[dir="rtl"] .text-start { text-align: right; }
+.text-end { text-align: right; }
+[dir="rtl"] .text-end { text-align: left; }
 
 /* Floats
  ******************************************************************************/
 
- .float-start { float: left !important; }
- [dir="rtl"] .float-start { float: right !important; }
- .float-end { float: right !important; }
- [dir="rtl"] .float-end { float: left !important; }
+ .float-start { float: left; }
+ [dir="rtl"] .float-start { float: right; }
+ .float-end { float: right; }
+ [dir="rtl"] .float-end { float: left; }
 
 /* Clearfix
  ******************************************************************************/
 
 .clearfix:after,
 .clearfix:before
 {
-  display: table !important;
-  content: " " !important;
+  display: table;
+  content: " ";
 }
 
 .clearfix:after
 {
-  clear: both !important;
+  clear: both;
 }
 
 /* Screen reader only
  ******************************************************************************/
 
 .sr-only
 {
-  position: absolute !important;
-  overflow: hidden !important;
-  clip: rect(0, 0, 0, 0) !important;
-  width: 1px !important;
-  height: 1px !important;
-  margin: -1px !important;
-  padding: 0 !important;
-  border: 0 !important;
+  position: absolute;
+  overflow: hidden;
+  clip: rect(0, 0, 0, 0);
+  width: 1px;
+  height: 1px;
+  margin: -1px;
+  padding: 0;
+  border: 0;
 }
 
 /* Unstyled elements
  ******************************************************************************/
 
 .unstyled,
-.unstyled *,
-.content .unstyled
+.unstyled *
 {
   margin: 0 !important;
   padding: 0 !important;
   border: 0 !important;
   background: none !important;
-}
-
-ul.unstyled
-{
   list-style: none !important;

[ire, 2017/12/05 09:30:13]

NIT: Is there a reason you removed the `list-style: none` style to not only be
applied to lists?

I don't actually know if we (eyeo) have a preference (coding style wise) for how
to handle cases like this. I..e is it better to apply all the styles to the one
class, or only target it to where it's needed, in this case lists. From the way
we handled the resets, my impression was that we prefer the latter. I have a
slight personal preference for the latter as well, but I recognise that the
former is better with file size. 

 }
 
 /* Backgrounds
  ******************************************************************************/
 
 .bg-primary
 {
-  color: $primary-light !important;
-  background-color: $primary-dark !important;
+  color: $primary-light;
+  background-color: $primary-dark;
 }
 
 .bg-secondary
 {
-  color: $secondary-light !important;
-  background-color: $secondary-dark !important;
+  color: $secondary-light;
+  background-color: $secondary-dark;
 }
 
 .bg-accent
 {
-  color: $accent-light !important;
-  background-color: $accent-dark !important;
+  color: $accent-light;
+  background-color: $accent-dark;
 }
 
 .bg-error
 {
-  color: $error-light !important;
-  background-color: $error-dark !important;
+  color: $error-light;
+  background-color: $error-dark;
 }
 
 /* Lead
  ******************************************************************************/
 
 .lead
 {
-  font-size: 1.25em !important;
+  font-size: 1.25em;
 }