Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(433)

Issue 29629558: Noissue - Add site name suffix to document title on help.eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 2 weeks ago by ire
Modified:
10 months, 1 week ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Noissue - Add site name suffix to document title on help.eyeo.com

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 3

Patch Set 3 : Set title_suffix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A locales/en/site.json View 1 chunk +6 lines, -0 lines 0 comments Download
M templates/article.tmpl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M templates/product-home.tmpl View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11
ire
10 months, 2 weeks ago (2017-12-04 11:24:20 UTC) #1
juliandoucette
Perhaps this should change to "| ${product} Help Center" when a product is selected?
10 months, 2 weeks ago (2017-12-04 13:01:32 UTC) #2
ire
On 2017/12/04 13:01:32, juliandoucette wrote: > Perhaps this should change to "| ${product} Help Center" ...
10 months, 2 weeks ago (2017-12-05 11:02:04 UTC) #3
ire
On 2017/12/05 11:02:04, ire wrote: > On 2017/12/04 13:01:32, juliandoucette wrote: > > Perhaps this ...
10 months, 2 weeks ago (2017-12-05 11:20:29 UTC) #4
juliandoucette
Is this still relevant than? (If not, will you close this review?)
10 months, 2 weeks ago (2017-12-05 16:44:40 UTC) #5
ire
On 2017/12/05 16:44:40, juliandoucette wrote: > Is this still relevant than? (If not, will you ...
10 months, 2 weeks ago (2017-12-06 09:39:03 UTC) #6
juliandoucette
LGTM - If you push this later, don't forget to fix the exclude suffix variable ...
10 months, 1 week ago (2017-12-13 15:07:21 UTC) #7
ire
https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-home.tmpl File templates/product-home.tmpl (right): https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-home.tmpl#newcode1 templates/product-home.tmpl:1: title_suffix={{ products[product_id].full_name }} Variables don't work here :( (Or ...
10 months, 1 week ago (2017-12-13 19:30:15 UTC) #8
juliandoucette
My bad :( https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-home.tmpl File templates/product-home.tmpl (right): https://codereview.adblockplus.org/29629558/diff/29638568/templates/product-home.tmpl#newcode1 templates/product-home.tmpl:1: title_suffix={{ products[product_id].full_name }} On 2017/12/13 19:30:14, ...
10 months, 1 week ago (2017-12-14 12:38:23 UTC) #9
ire
On 2017/12/14 12:38:23, juliandoucette wrote: > My bad :( Your suggestion worked :) (Waiting for ...
10 months, 1 week ago (2017-12-14 14:58:11 UTC) #10
juliandoucette
10 months, 1 week ago (2017-12-14 15:47:57 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5