Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29630066: Noissue - Updated locales from Crowdin (adblockpluschrome) (Closed)

Created:
Dec. 4, 2017, 2:31 p.m. by kzar
Modified:
Dec. 6, 2017, 1:29 p.m.
Reviewers:
tamara, Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Noissue - Updated locales from Crowdin (adblockpluschrome)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed as/messages.json #

Patch Set 3 : Pulled translations again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -100 lines) Patch
M _locales/am/messages.json View 2 chunks +15 lines, -0 lines 0 comments Download
M _locales/ar/messages.json View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M _locales/be/messages.json View 9 chunks +15 lines, -12 lines 0 comments Download
M _locales/bg/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/ca/messages.json View 1 2 12 chunks +21 lines, -18 lines 0 comments Download
M _locales/el/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/es/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/es_CL/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/et/messages.json View 10 chunks +18 lines, -15 lines 0 comments Download
M _locales/fi/messages.json View 5 chunks +9 lines, -6 lines 0 comments Download
M _locales/fr/messages.json View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/he/messages.json View 5 chunks +20 lines, -11 lines 0 comments Download
M _locales/it/messages.json View 2 chunks +4 lines, -1 line 0 comments Download
M _locales/ko/messages.json View 1 chunk +9 lines, -0 lines 0 comments Download
M _locales/nl/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/pl/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/pt_PT/messages.json View 5 chunks +11 lines, -5 lines 0 comments Download
M _locales/ro/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/ru/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/sl/messages.json View 2 chunks +6 lines, -0 lines 0 comments Download
M _locales/th/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/tr/messages.json View 13 chunks +35 lines, -32 lines 0 comments Download
M _locales/uz/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
Dec. 4, 2017, 2:35 p.m. (2017-12-04 14:35:30 UTC) #1
Wladimir Palant
LGTM if you remove the file mentioned below. https://codereview.adblockplus.org/29630066/diff/29630067/_locales/as/messages.json File _locales/as/messages.json (right): https://codereview.adblockplus.org/29630066/diff/29630067/_locales/as/messages.json#newcode5 _locales/as/messages.json:5: } ...
Dec. 4, 2017, 6:20 p.m. (2017-12-04 18:20:21 UTC) #2
kzar
Patch Set 2 : Removed as/messages.json https://codereview.adblockplus.org/29630066/diff/29630067/_locales/as/messages.json File _locales/as/messages.json (right): https://codereview.adblockplus.org/29630066/diff/29630067/_locales/as/messages.json#newcode5 _locales/as/messages.json:5: } On 2017/12/04 ...
Dec. 4, 2017, 6:25 p.m. (2017-12-04 18:25:45 UTC) #3
Wladimir Palant
LGTM
Dec. 4, 2017, 6:35 p.m. (2017-12-04 18:35:47 UTC) #4
kzar
Patch Set 3 : Pulled translations again
Dec. 6, 2017, 1:11 p.m. (2017-12-06 13:11:06 UTC) #5
tamara
Dec. 6, 2017, 1:17 p.m. (2017-12-06 13:17:22 UTC) #6 
On 2017/12/06 13:11:06, kzar wrote:
> Patch Set 3 : Pulled translations again

LGTM

Powered by Google App Engine
This is Rietveld