Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/meta/standard.tmpl

Issue 29630648: Issue 6013 - Add site name to document title in website-defaults standard metadata (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Created Dec. 5, 2017, 11:19 a.m.
Right Patch Set: Remove repeated markup Created Dec. 13, 2017, 9:38 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | pages/index.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <meta charset="utf-8"> 1 <meta charset="utf-8">
2 <meta http-equiv="x-ua-compatible" content="ie=edge"> 2 <meta http-equiv="x-ua-compatible" content="ie=edge">
3 <meta name="viewport" content="width=device-width, initial-scale=1"> 3 <meta name="viewport" content="width=device-width, initial-scale=1">
4 4
5 {% if title_suffix == 'none' or (not title_suffix and not has_string("name", "si te")) %}
6 <title> 5 <title>
7 {{ title | translate("page-title", "Page title") }} 6 {{ title | translate("title", "Page title") }}
7
juliandoucette 2017/12/13 15:01:10 NIT: Unnecessary empty line?
ire 2017/12/13 19:16:00 Done.
8 {% if title_suffix and title_suffix != 'none' %}
9 | {{ title_suffix | translate("title-suffix", "Page title suffix") }}
10 {% elif has_string("name", "site") and title_suffix != 'none' %}
11 | {{ get_string("name", "site") }}
12 {% endif %}
8 </title> 13 </title>
9 {% elif title_suffix %}
10 <title>
11 {{ title | translate("page-title", "Page title") }} | {{ title_suffix }}
juliandoucette 2017/12/06 17:07:17 You forgot the translate filter.
ire 2017/12/07 13:35:10 Done.
12 </title>
13 {% elif has_string("name", "site") %}
14 <title>
15 {{ title | translate("page-title", "Page title") }} | {{ get_string("name", "s ite") }}
16 </title>
17 {% endif %}
18 14
19 {% if description %} 15 {% if description %}
20 <meta name="description" content="{{ description | translate("page-description ", "Page description") }}"> 16 <meta name="description" content="{{ description | translate("page-description ", "Page description") }}">
21 {% endif %} 17 {% endif %}
22 <link rel="canonical" href="{{ get_canonical_url(page) }}"> 18 <link rel="canonical" href="{{ get_canonical_url(page) }}">
LEFTRIGHT
« no previous file | pages/index.html » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld