Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29631219: Issue 4105 - [build] Make it possible to build arbitrary ABB revisions (Closed)

Created:
Dec. 5, 2017, 3:04 p.m. by diegocarloslima
Modified:
Dec. 6, 2017, 2:19 p.m.
Reviewers:
René Jeschke, anton, jens
Visibility:
Public.

Description

Issue 4105 - [build] Make it possible to build arbitrary ABB revisions

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -385 lines) Patch
M abb-build/build.py View 1 chunk +3 lines, -2 lines 0 comments Download
R abb-build/dependencies View 1 chunk +0 lines, -3 lines 0 comments Download
R abb-build/ensure_dependencies.py View 1 chunk +0 lines, -380 lines 0 comments Download
M dependencies View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 4
diegocarloslima
Dec. 5, 2017, 3:05 p.m. (2017-12-05 15:05:28 UTC) #1
jens
On 2017/12/05 15:05:28, diegocarloslima wrote: LGTM
Dec. 5, 2017, 3:11 p.m. (2017-12-05 15:11:50 UTC) #2
anton
https://codereview.adblockplus.org/29631219/diff/29631220/dependencies File dependencies (right): https://codereview.adblockplus.org/29631219/diff/29631220/dependencies#newcode5 dependencies:5: abb-build/mozharness = mozharness hg:2987360d15cd LGTM though i'd say it ...
Dec. 5, 2017, 3:37 p.m. (2017-12-05 15:37:04 UTC) #3
René Jeschke
Dec. 6, 2017, 9:27 a.m. (2017-12-06 09:27:28 UTC) #4
On 2017/12/05 15:37:04, anton wrote:
> https://codereview.adblockplus.org/29631219/diff/29631220/dependencies
> File dependencies (right):
> 
>
https://codereview.adblockplus.org/29631219/diff/29631220/dependencies#newcode5
> dependencies:5: abb-build/mozharness = mozharness hg:2987360d15cd
> LGTM though i'd say it will not work for git, so i'd prefer to remove git
> revisions for all other deps.

LGTM, too. Like Anton said, as there's no Git revision for mozharness, multi
language builds won't work with git, but this is fine with me. If we remove the
other Git revisions, then everybody is forced to use Mercurial for development,
which makes no sense IMHO. So, I've go no problem with the fact that l10n
release-/dev-builds only work with Mercurial.

Powered by Google App Engine
This is Rietveld