Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(720)

Issue 29632569: Issue 6113 - Improve reliability of "block element" dialog (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by kzar
Modified:
2 days, 4 hours ago
Reviewers:
Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 6113 - Improve reliability of "block element" dialog

Patch Set 1 #

Total comments: 3

Patch Set 2 : Simplify response checking logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M composer.js View 1 chunk +9 lines, -0 lines 0 comments Download
M lib/filterComposer.js View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1 This will improve things for all Windows + Firefox users, making the ...
1 week ago (2017-12-07 13:20:11 UTC) #1
kzar
https://codereview.adblockplus.org/29632569/diff/29632570/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29632569/diff/29632570/lib/filterComposer.js#newcode241 lib/filterComposer.js:241: if (doInitAttempt > 30) With other versions of Firefox ...
1 week ago (2017-12-07 13:28:33 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29632569/diff/29632570/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29632569/diff/29632570/lib/filterComposer.js#newcode252 lib/filterComposer.js:252: if (typeof response == "undefined") Nit: why not `if ...
2 days, 4 hours ago (2017-12-12 12:14:52 UTC) #3
kzar
Patch Set 2 : Simplify response checking logic https://codereview.adblockplus.org/29632569/diff/29632570/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29632569/diff/29632570/lib/filterComposer.js#newcode252 lib/filterComposer.js:252: if ...
2 days, 4 hours ago (2017-12-12 12:33:15 UTC) #4
Wladimir Palant
2 days, 4 hours ago (2017-12-12 12:40:30 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5