Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29633092: Fixes #6172 - Update provisioning profiles to allow for building on devices using debug (Closed)

Created:
Dec. 7, 2017, 3:08 p.m. by a.shephard
Modified:
Jan. 3, 2018, 11:45 a.m.
Reviewers:
d108, dean
Visibility:
Public.

Description

Fixes #6172 - Update provisioning profiles to allow for building on devices using debug

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M AdblockBrowser.xcodeproj/project.pbxproj View 5 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5
a.shephard
Dec. 7, 2017, 3:08 p.m. (2017-12-07 15:08:58 UTC) #1
dean
On 2017/12/07 15:08:58, a.shephard wrote: LGTM
Dec. 7, 2017, 3:48 p.m. (2017-12-07 15:48:01 UTC) #2
d108
The following paths have been removed from AdblockBrowser.xcodeproj: project.xcworkspace xcshareddata/xcschemes/AdblockBrowser.xcscheme xcshareddata/xcschemes/AdblockBrowserTests.xcscheme xcshareddata/xcschemes/ExtensionShare.xcscheme They should be ...
Dec. 14, 2017, 10:39 p.m. (2017-12-14 22:39:00 UTC) #3
a.shephard
On 2017/12/14 22:39:00, d108 wrote: > The following paths have been removed from AdblockBrowser.xcodeproj: > ...
Dec. 18, 2017, 9:42 a.m. (2017-12-18 09:42:23 UTC) #4
d108
Dec. 18, 2017, 3:59 p.m. (2017-12-18 15:59:37 UTC) #5
On 2017/12/18 09:42:23, a.shephard wrote:
> On 2017/12/14 22:39:00, d108 wrote:
> > The following paths have been removed from AdblockBrowser.xcodeproj:
> > 
> > project.xcworkspace
> > xcshareddata/xcschemes/AdblockBrowser.xcscheme
> > xcshareddata/xcschemes/AdblockBrowserTests.xcscheme
> > xcshareddata/xcschemes/ExtensionShare.xcscheme
> > 
> > They should be restored.
> 
> How do I restore these? I'm seeing the files still existing in the project
> folder and within Xcode it seems all is normal. I've checked diffs between
this
> commit and the previous one and I'm not seeing any changes related to paths.

LGTM - I see the problem now. Rietveld or our upload script strips the package
contents of the Xcode project. The changes can then be evaluated by copying the
standalone project into a project package.

Powered by Google App Engine
This is Rietveld