Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1184)

Issue 29637578: Issue 6182 - Add build step for fonts and images in help.eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by ire
Modified:
1 year, 6 months ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 6182 - Add build step for fonts and images in help.eyeo.com

Patch Set 1 #

Patch Set 2 : Remove contents of dist directory #

Total comments: 11

Patch Set 3 : Remove imagemin from fonts build step #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, --22 lines) Patch
M .gitignore View 1 1 chunk +1 line, -2 lines 0 comments Download
M .hgignore View 1 1 chunk +1 line, -2 lines 0 comments Download
M gulpfile.js View 1 2 2 chunks +31 lines, -1 line 0 comments Download
M package.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M static/src/fonts/Source-Sans-Pro-400/LICENSE.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.eot View 1 Binary file 0 comments Download
M static/src/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.ttf View 1 Binary file 0 comments Download
M static/src/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.woff View 1 Binary file 0 comments Download
M static/src/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.woff2 View 1 Binary file 0 comments Download
M static/src/fonts/Source-Sans-Pro-600/LICENSE.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.eot View 1 Binary file 0 comments Download
M static/src/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.ttf View 1 Binary file 0 comments Download
M static/src/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.woff View 1 Binary file 0 comments Download
M static/src/fonts/Source-Sans-Pro-600/Source-Sans-Pro-600.woff2 View 1 Binary file 0 comments Download
M static/src/img/png/accent-bg.png View 1 Binary file 0 comments Download
M static/src/img/png/arrow-icon-down-secondary.png View 1 Binary file 0 comments Download
M static/src/img/png/arrow-icon-left-gray.png View 1 Binary file 0 comments Download
M static/src/img/png/arrow-icon-right-gray.png View 1 Binary file 0 comments Download
M static/src/img/png/arrow-icon-secondary.png View 1 Binary file 0 comments Download
M static/src/img/png/chrome.png View 1 Binary file 0 comments Download
M static/src/img/png/email-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/external-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/eyeo-help.png View 1 Binary file 0 comments Download
M static/src/img/png/firefox.png View 1 Binary file 0 comments Download
M static/src/img/png/help-bg.png View 1 Binary file 0 comments Download
M static/src/img/png/install-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/ios.png View 1 Binary file 0 comments Download
M static/src/img/png/logo-abp.png View 1 Binary file 0 comments Download
M static/src/img/png/logo-facebook.png View 1 Binary file 0 comments Download
M static/src/img/png/logo-twitter.png View 1 Binary file 0 comments Download
M static/src/img/png/maxthon.png View 1 Binary file 0 comments Download
M static/src/img/png/mobile-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/msedge.png View 1 Binary file 0 comments Download
M static/src/img/png/msie.png View 1 Binary file 0 comments Download
M static/src/img/png/opera.png View 1 Binary file 0 comments Download
M static/src/img/png/popular-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/reporting-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/safari.png View 1 Binary file 0 comments Download
M static/src/img/png/samsungBrowser.png View 1 Binary file 0 comments Download
M static/src/img/png/search-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/settings-icon.png View 1 Binary file 0 comments Download
M static/src/img/png/yandexbrowser.png View 1 Binary file 0 comments Download
M static/src/img/svg/arrow-icon-down-secondary.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/arrow-icon-secondary.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/chrome.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/email-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/external-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/eyeo-help.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/firefox.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/install-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/ios.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/logo-abp.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/logo-facebook.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/logo-twitter.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/maxthon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/mobile-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/msedge.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/msie.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/opera.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/popular-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/reporting-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/safari.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/samsungBrowser.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/search-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/settings-icon.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M static/src/img/svg/yandexbrowser.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10
ire
1 year, 7 months ago (2017-12-13 12:09:42 UTC) #1
ire
Ready for review https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js#newcode83 gulpfile.js:83: return gulp.src(["./static/src/fonts/**"]) I couldn't find any ...
1 year, 7 months ago (2017-12-13 12:15:44 UTC) #2
juliandoucette
Relevant: https://gitlab.com/eyeo/websites-docs/issues/1 I'm hesitant to add an image optimization step to our build process because ...
1 year, 7 months ago (2017-12-13 16:22:48 UTC) #3
ire
On 2017/12/13 16:22:48, juliandoucette wrote: > Relevant: https://gitlab.com/eyeo/websites-docs/issues/1 > > I'm hesitant to add an ...
1 year, 7 months ago (2017-12-14 09:07:33 UTC) #4
juliandoucette
> I just think it should be something that happens > (essentially) automatically, and without ...
1 year, 7 months ago (2017-12-14 13:01:45 UTC) #5
ire
https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js#newcode66 gulpfile.js:66: .pipe(imagemin([ On 2017/12/14 13:01:44, juliandoucette wrote: > This could ...
1 year, 7 months ago (2017-12-16 09:59:25 UTC) #6
juliandoucette
https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js#newcode66 gulpfile.js:66: .pipe(imagemin([ On 2017/12/16 09:59:24, ire wrote: > If I ...
1 year, 7 months ago (2017-12-18 17:11:17 UTC) #7
ire
https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js#newcode66 gulpfile.js:66: .pipe(imagemin([ On 2017/12/18 17:11:16, juliandoucette wrote: > On 2017/12/16 ...
1 year, 7 months ago (2017-12-20 08:44:21 UTC) #8
juliandoucette
LGTM (Use your best judgement about the issue below). https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js#newcode83 gulpfile.js:83: ...
1 year, 6 months ago (2018-01-04 15:45:36 UTC) #9
ire
1 year, 6 months ago (2018-01-05 07:56:10 UTC) #10
https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js
File gulpfile.js (right):

https://codereview.adblockplus.org/29637578/diff/29637580/gulpfile.js#newcode83
gulpfile.js:83: return gulp.src(["./static/src/fonts/**"])
On 2018/01/04 15:45:35, juliandoucette wrote:
> On 2017/12/20 08:44:20, ire wrote:
> > On 2017/12/18 17:11:16, juliandoucette wrote:
> > > I think we can exclude this then (and add it later if necessary).
> > 
> > Do you mean to exclude this whole task? Or to exclude the imagemin?
> 
> Exclude imagemin. Excluding the whole task would mean moving fonts from src to
> dist and not ignoring dist (which I may not have a problem with, but it's
> unnecessary).

Ack. That's what I thought, just confirming. Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5