Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 29640558: Issue 6187 - Adjust query string parameters for Yandex (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by jens
Modified:
1 year, 9 months ago
Reviewers:
anton, diegocarloslima
CC:
René Jeschke
Visibility:
Public.

Description

Issue 6187 - Adjust query string parameters for Yandex

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added package name of alpha and beta versions of both browsers #

Total comments: 2

Patch Set 3 : Renamed method to isPackageInstalled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java View 1 2 3 chunks +43 lines, -1 line 0 comments Download

Messages

Total messages: 8
jens
1 year, 9 months ago (2017-12-15 16:04:36 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29640558/diff/29640559/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java (right): https://codereview.adblockplus.org/29640558/diff/29640559/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java#newcode134 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java:134: private String checkForCompatibleInstalledBrowser(final PackageManager packageManager) I think that we ...
1 year, 9 months ago (2017-12-15 16:13:43 UTC) #2
jens
https://codereview.adblockplus.org/29640558/diff/29640559/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java (right): https://codereview.adblockplus.org/29640558/diff/29640559/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java#newcode134 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java:134: private String checkForCompatibleInstalledBrowser(final PackageManager packageManager) On 2017/12/15 16:13:43, diegocarloslima ...
1 year, 9 months ago (2017-12-18 08:41:34 UTC) #3
jens
On 2017/12/18 08:41:34, jens wrote: > https://codereview.adblockplus.org/29640558/diff/29640559/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java > File > adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java > (right): > > ...
1 year, 9 months ago (2017-12-18 08:44:00 UTC) #4
diegocarloslima
https://codereview.adblockplus.org/29640558/diff/29643555/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java (right): https://codereview.adblockplus.org/29640558/diff/29643555/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java#newcode157 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java:157: private boolean packageIsInstalled(final PackageManager packageManager, final String packageName) I ...
1 year, 9 months ago (2017-12-18 09:15:30 UTC) #5
jens
Added a new patch set https://codereview.adblockplus.org/29640558/diff/29643555/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java (right): https://codereview.adblockplus.org/29640558/diff/29643555/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java#newcode157 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java:157: private boolean packageIsInstalled(final PackageManager ...
1 year, 9 months ago (2017-12-18 09:29:48 UTC) #6
diegocarloslima
On 2017/12/18 09:29:48, jens wrote: > Added a new patch set > > https://codereview.adblockplus.org/29640558/diff/29643555/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/AppInfo.java > ...
1 year, 9 months ago (2017-12-18 09:58:09 UTC) #7
anton
1 year, 9 months ago (2017-12-19 09:15:53 UTC) #8
On 2017/12/15 16:04:36, jens wrote:

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5