pages/index.html - Issue 29643557: Issue 5442 - Add logo microdata to eyeo websites

Delta Between Two Patch Sets: pages/index.html

Issue 29643557: Issue 5442 - Add logo microdata to eyeo websites (Closed) Base URL: https://hg.adblockplus.org/web.eyeo.com

Left Patch Set: Created Dec. 18, 2017, 8:54 a.m.

Right Patch Set: Move schema to <head>, use black logo Created Jan. 3, 2018, 2 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 title=About Us

2 description=Founded in 2011, eyeo is the company behind Adblock Plus, Adblock Br owser and Flattr. We build products that millions of people use everyday to impr ove their online experience.

3

4 <? include index/style ?>

5

6 <div id="home-image-container">

7 <img alt="eyeo office" src="/images/eyeo-home-1x.png" />

8 </div>

9

10 <div id="who-we-are" class="content-block columns-container two-columns">

11 <div class="column" markdown="1">

12 <? include index/whoweare ?>

13 </div>

14

15 <div class="column">

16 <? include index/mission ?>

17 </div>

18 </div>

19

20 <div id="our-work">

21 <div class="content-block">

22 <h1 class="heading centered"><span>What we are working on:</span></h1>

23

24 <div class="columns-container four-columns">

25 <div class="column">

26 <? include index/ourwork-betterads ?>

27 </div>

28

29 <div class="column">

30 <? include index/ourwork-privacy ?>

31 </div>

32

33 <div class="column">

34 <? include index/ourwork-security ?>

35 </div>

36

37 <div class="column">

38 <? include index/ourwork-opensource ?>

39 </div>

40 </div>

41 </div>

42 </div>

43

44 <div id="media" class="content-block">

45 <? include index/media ?>

46 </div>

47

48 <script type="application/ld+json">
juliandoucette 2017/12/18 13:21:59 See first comment in default.tmpl See first comment in default.tmpl ire 2017/12/20 08:25:59 Acknowledged. Show quoted text On 2017/12/18 13:21:59, juliandoucette wrote: > See first comment in default.tmpl Acknowledged.
49 {

50 "@context": "http://schema.org",

51 "@type": "Organization",
juliandoucette 2017/12/18 13:21:59 TOL: Now that we are defining Organization meta da TOL: Now that we are defining Organization meta data, it seems like things are obviously missing e.g. "name". This is ok, and we can add anything that we want separately, as long as defining this script block doesn't override other forms of macro data collection (as long as it's not one format or the other). juliandoucette 2017/12/18 13:21:59 TOL: We could define this in python (e.g. meta dat TOL: We could define this in python (e.g. meta data, global, or include) and then use a global/filter to output it in JSON ire 2017/12/20 08:25:59 - Yes there are already other issues for adding mo Show quoted text On 2017/12/18 13:21:59, juliandoucette wrote: > TOL: Now that we are defining Organization meta data, it seems like things are > obviously missing e.g. "name". This is ok, and we can add anything that we want > separately, as long as defining this script block doesn't override other forms > of macro data collection (as long as it's not one format or the other). - Yes there are already other issues for adding more microdata information - I don't think it's "one format or the other", I think we can supplement the markup microdata. But we can also just add the additional microdata here, this JSON format is the preferred version according to the docs ire 2017/12/20 08:25:59 Sorry, I don't quite understand. Since the data wi Show quoted text On 2017/12/18 13:21:59, juliandoucette wrote: > TOL: We could define this in python (e.g. meta data, global, or include) and > then use a global/filter to output it in JSON Sorry, I don't quite understand. Since the data will be different for each page, what exactly should we define in a python global? Just this line that specifies the @type? juliandoucette 2017/12/20 11:50:16 We could define a global macrodata object, extend Show quoted text On 2017/12/20 08:25:59, ire wrote: > Sorry, I don't quite understand. Since the data will be different for each page, > what exactly should we define in a python global? Just this line that specifies > the @type? We could define a global macrodata object, extend it in pages and includes, output it in json in a template. Yes, @context, @type, anything else that is not page specific. We should probably do this separately when we extend the macrodata in the future. ire 2018/01/03 14:01:18 Ack. Agreed. Show quoted text On 2017/12/20 11:50:16, juliandoucette wrote: > On 2017/12/20 08:25:59, ire wrote: > > Sorry, I don't quite understand. Since the data will be different for each > page, > > what exactly should we define in a python global? Just this line that > specifies > > the @type? > > We could define a global macrodata object, extend it in pages and includes, > output it in json in a template. > > Yes, @context, @type, anything else that is not page specific. > > We should probably do this separately when we extend the macrodata in the > future. Ack. Agreed.
52 "url": "{{ config.get("general", "siteurl") }}",

53 "logo": "{{ config.get("general", "siteurl") }}/images/logo-3x.png"

54 }

55 </script>

LEFT	RIGHT