Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/index.html

Issue 29643557: Issue 5442 - Add logo microdata to eyeo websites (Closed) Base URL: https://hg.adblockplus.org/web.eyeo.com
Patch Set: Created Dec. 18, 2017, 8:54 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | static/images/logo-3x.png » ('j') | templates/default.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/index.html
===================================================================
--- a/pages/index.html
+++ b/pages/index.html
@@ -39,8 +39,17 @@
</div>
</div>
</div>
</div>
<div id="media" class="content-block">
<? include index/media ?>
</div>
+
+<script type="application/ld+json">
juliandoucette 2017/12/18 13:21:59 See first comment in default.tmpl
ire 2017/12/20 08:25:59 Acknowledged.
+ {
+ "@context": "http://schema.org",
+ "@type": "Organization",
juliandoucette 2017/12/18 13:21:59 TOL: Now that we are defining Organization meta da
juliandoucette 2017/12/18 13:21:59 TOL: We could define this in python (e.g. meta dat
ire 2017/12/20 08:25:59 - Yes there are already other issues for adding mo
ire 2017/12/20 08:25:59 Sorry, I don't quite understand. Since the data wi
juliandoucette 2017/12/20 11:50:16 We could define a global macrodata object, extend
ire 2018/01/03 14:01:18 Ack. Agreed.
+ "url": "{{ config.get("general", "siteurl") }}",
+ "logo": "{{ config.get("general", "siteurl") }}/images/logo-3x.png"
+ }
+</script>
« no previous file with comments | « no previous file | static/images/logo-3x.png » ('j') | templates/default.tmpl » ('J')

Powered by Google App Engine
This is Rietveld