index.html - Issue 29646555: Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter

Side by Side Diff: index.html

Issue 29646555: Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter (Closed)

Patch Set: Created Dec. 21, 2017, 11:25 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html lang="en" dir="ltr">

	3 <head>

	4 <meta charset="utf-8">

	5 <title>Adblock Plus newsletter signup form</title>

	6 <meta name="viewport" content="width=device-width, initial-scale=1">

	7 <link rel="stylesheet" type="text/css" href="css/main.min.css">
	ire 2017/12/21 11:54:05 In the actual implementation, I will likely inline In the actual implementation, I will likely inline these styles because: - I'm not sure how to host files with Backclick - The stylesheet isn't that big so we might as well not have an additional resource to have to fetch However, I'm not sure if: 1. We can inline the minified file (no sourcemaps) 2. We need to have a licence My suggestion is, if you don't have an answer right now, that we inline the minified file and update later if necessary saroyanm 2017/12/21 16:07:57 Do they have an API documentation in English ? The Show quoted text On 2017/12/21 11:54:05, ire wrote: > In the actual implementation, I will likely inline these styles because: > - I'm not sure how to host files with Backclick Do they have an API documentation in English ? They site seems to be only in German. Show quoted text > - The stylesheet isn't that big so we might as well not have an additional > resource to have to fetch This is a relatively simple page, we might be able to have a simple Internal CSS without website-defaults, but I'll leave it up to you and Julian to decide if having whole websites defaults minified here is necessary or not(it doesn't look like that to me though). Also that might mean that we will have Internal Scripts, depending on how we would like to handle validations. Show quoted text > However, I'm not sure if: > 1. We can inline the minified file (no sourcemaps) > 2. We need to have a licence Having HTML header, should be sufficient. Show quoted text > > My suggestion is, if you don't have an answer right now, that we inline the > minified file and update later if necessary ire 2017/12/22 10:33:22 No they don't :( I've just been trying to figure Show quoted text On 2017/12/21 16:07:57, saroyanm wrote: > On 2017/12/21 11:54:05, ire wrote: > > In the actual implementation, I will likely inline these styles because: > > - I'm not sure how to host files with Backclick > Do they have an API documentation in English ? > They site seems to be only in German. No they don't :( I've just been trying to figure out how they do things by trial and also using Google translate for some sentences. Show quoted text > > - The stylesheet isn't that big so we might as well not have an additional > > resource to have to fetch > This is a relatively simple page, we might be able to have a simple Internal CSS > without website-defaults, but I'll leave it up to you and Julian to decide if > having whole websites defaults minified here is necessary or not(it doesn't look > like that to me though). You're right. I will only include the specific files I'm using instead of the whole of website-defaults saroyanm 2017/12/22 12:26:10 That's a shame that we have choose a German provid Show quoted text On 2017/12/22 10:33:22, ire wrote: > On 2017/12/21 16:07:57, saroyanm wrote: > > On 2017/12/21 11:54:05, ire wrote: > > > In the actual implementation, I will likely inline these styles because: > > > - I'm not sure how to host files with Backclick > > Do they have an API documentation in English ? > > They site seems to be only in German. > > No they don't :( That's a shame that we have choose a German provider without English support, this shouldn't have happened on the first place. I wonder if that question was raised already ? Anyway -> https://issues.adblockplus.org/ticket/6210#comment:15 Show quoted text > I've just been trying to figure out how they do things by trial and also using > Google translate for some sentences. > > > > - The stylesheet isn't that big so we might as well not have an additional > > > resource to have to fetch > > This is a relatively simple page, we might be able to have a simple Internal > CSS > > without website-defaults, but I'll leave it up to you and Julian to decide if > > having whole websites defaults minified here is necessary or not(it doesn't > look > > like that to me though). > > You're right. I will only include the specific files I'm using instead of the > whole of website-defaults >
	8 </head>

	9 <body>

	10 <div class="outer-container">

	11 <div class="container phablet-width content">

	12

	13 <header id="header">

	14 <h1 id="title">

	15 <img src="img/abp-logo.png" srcset="img/abp-logo.svg 2x" alt="ABP insi de red octagon">
	ire 2017/12/21 11:54:05 I used this logo instead of the full one (with tex I used this logo instead of the full one (with text) because I think it looks better to have the "AdblockPlus" in actual text and because this is the way it's done in the extension UI.
	16 <span>Adblock<strong>Plus</strong></span>

	17 </h1>

	18 <p class="lead"><strong>Sign up for the Adblock Plus newsletter</strong> </p>

	19 <p>Stay up to date with all things Adblock Plus</p>

	20 </header>

	21

	22 <form class="phone-width align-center">

	23 <label for="email">Email Address *</label>

	24 <input type="email" id="email" name="email" required>
	ire 2017/12/21 11:54:05 You can demo what it would look like if this field You can demo what it would look like if this field is incorrect by adding the class, "input_round_error" to it saroyanm 2017/12/21 16:07:57 Acknowledged. Show quoted text On 2017/12/21 11:54:05, ire wrote: > You can demo what it would look like if this field is incorrect by adding the > class, "input_round_error" to it Acknowledged.
	25 <span class="error-message">Please enter a valid email address</span>

	26

	27 <label for="fullname">Full name</label>

	28 <input type="text" id="fullname" name="fullname">

	29

	30 <button type="submit" class="button secondary">Sign Up</button>

	31

	32 <p class="text-center">

	33 <a href="https://adblockplus.org/en/privacy" target="_blank">Privacy P olicy</a>

	34 </p>

	35 </form>

	36 </div>

	37 </div>

	38 </body>

	39 </html>

OLD	NEW

« no previous file with comments | « img/abp-logo.svg ('k') | package.json » ('j') | no next file with comments »