scss/_vars.scss - Issue 29646555: Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: scss/_vars.scss

Issue 29646555: Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter (Closed)

Patch Set: Update hgignore Created Dec. 21, 2017, 11:50 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ////////////////////////////////////////////////////////////////////////////////

	2 // Variables

	3 ////////////////////////////////////////////////////////////////////////////////

	4

	5 // Brand colors

	6 ////////////////////////////////////////////////////////////////////////////////

	7

	8 $secondary: #C70D2B;

	9

	10 // Fonts

	11 ////////////////////////////////////////////////////////////////////////////////

	12

	13 $primary-font: "Source Sans Pro", sans-serif;

	14

	15 // Spacing

	16 ////////////////////////////////////////////////////////////////////////////////

	17

	18 $x-small-space: 0.5em;

	19

	20 // Device widths

	21 ////////////////////////////////////////////////////////////////////////////////

	22

	23 $phone-width: 320px;
	saroyanm 2017/12/21 16:07:59 Seems like we are only using this variable to set Seems like we are only using this variable to set the width of the form(until I'm missing smth.), I'll suggest to use different variable for the purpose, ex: form-width. ire 2017/12/22 10:33:26 This was for consistency with website-defaults. Bu Show quoted text On 2017/12/21 16:07:59, saroyanm wrote: > Seems like we are only using this variable to set the width of the form(until > I'm missing smth.), I'll suggest to use different variable for the purpose, ex: > form-width. This was for consistency with website-defaults. But it's not relevant anymore because I've removed it. juliandoucette 2017/12/22 13:32:24 Acknowledged. Show quoted text On 2017/12/22 10:33:26, ire wrote: > On 2017/12/21 16:07:59, saroyanm wrote: > > Seems like we are only using this variable to set the width of the form(until > > I'm missing smth.), I'll suggest to use different variable for the purpose, > ex: > > form-width. > > This was for consistency with website-defaults. But it's not relevant anymore > because I've removed it. Acknowledged.
OLD	NEW

« scss/_layout.scss ('K') | « scss/_layout.scss ('k') | scss/main.scss » ('j') | no next file with comments »