Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: gulpfile.js

Issue 29646555: Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter (Closed)
Patch Set: Update confirmation and success texts Created Jan. 3, 2018, 11:43 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*!
2 * This file is part of adblockplus.org.
juliandoucette 2018/01/04 02:34:22 This is actually part of eyeomail.com?
ire 2018/01/04 11:14:41 Done.
3 * Copyright (C) 2017-present eyeo GmbH
4 *
5 * adblockplus.org is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License as published by
7 * the Free Software Foundation, either version 3 of the License, or
8 * (at your option) any later version.
9 *
10 * adblockplus.org is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with adblockplus.org. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19 const gulp = require("gulp");
20 const gutil = require("gulp-util");
21 const rename = require("gulp-rename");
22 const sass = require("gulp-sass");
23 const postcss = require("gulp-postcss");
24 const scss = require("postcss-scss");
25 const autoprefixer = require("autoprefixer");
26 const replace = require("replace");
27 const fs = require('fs');
28
29 /******************************************************************************
30 * CSS
31 ******************************************************************************/
32
33 gulp.task("compileCss", function() {
34 return gulp.src("./scss/main.scss")
35 .pipe(postcss([autoprefixer()], {syntax: scss}).on("error", gutil.log))
36 .pipe(sass({outputStyle: "compact"}).on("error", gutil.log))
juliandoucette 2018/01/04 02:34:19 I don't think we should minify without source maps
ire 2018/01/04 11:14:41 This isn't minifying?
37 .pipe(gulp.dest("./css"));
38 });
39
40 gulp.task("inlineCss", function() {
41 return fs.readFile('./css/main.css', 'utf8', function (err, styles) {
juliandoucette 2018/01/04 02:34:22 NIT: single quotes.
ire 2018/01/04 11:14:40 Done.
42 if (err) throw err;
43
44 const replacement = `<!-- styles:start -->
juliandoucette 2018/01/04 02:34:23 NIT: Why not shorten this e.g. `<style>${styles}</
ire 2018/01/04 11:14:41 I think it looks better when the styles start on t
45 <style>
46 ${styles}
47 </style>
48 <!-- styles:end -->`;
49
50 replace({
51 regex: /<!-- styles:start -->([\s\S]*?)<!-- styles:end -->/,
juliandoucette 2018/01/04 02:34:23 NIT: Why not shorten this? e.g. `<!-- styles /-->`
ire 2018/01/04 11:14:40 This is "sort of" (in mega quotes) a convention fo
52 replacement: replacement,
53 paths: ['./index.html', 'backclick.html'],
juliandoucette 2018/01/04 02:34:22 NIT: Can't we *just* do this to backclick.html?
ire 2018/01/04 11:14:42 I was keeping the other file around so that we can
54 recursive: true,
juliandoucette 2018/01/04 02:34:21 NIT: I don't think recursive or silent are necessa
ire 2018/01/04 11:14:40 I just copied the default example here. Is there a
55 silent: true,
56 });
57 });
58 });
59
60 gulp.task("css", ["compileCss", "inlineCss"]);
61
62 /******************************************************************************
63 * Watch
64 ******************************************************************************/
65
66 gulp.task("watch", function() {
67 gulp.watch("./scss/**/*.scss", ["css"]);
68 });
69
70 /******************************************************************************
71 * Default
72 ******************************************************************************/
73
74 gulp.task("default", ["css", "watch"]);
OLDNEW

Powered by Google App Engine
This is Rietveld