Unified Diff: index.html
Issue 29646555:
Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter (Closed)
Patch Set: Update privacy policy link
Created Dec. 22, 2017, 11:44 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« img/abp-logo.svg ('k')
|
package.json » ('j')
|
scss/_content.scss » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: index.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/index.html |
| @@ -0,0 +1,44 @@ |
| +<!doctype html> |
| +<html lang="en" dir="ltr"> |
| +<head> |
| + <!-- Website Defaults Standard Metadata --> |
|
juliandoucette
2017/12/22 14:34:30
TOL: Is <!-- website-defaults/includes/meta/standa
ire
2017/12/22 16:29:37
Done.
|
| + <meta charset="utf-8"> |
| + <meta http-equiv="x-ua-compatible" content="ie=edge"> |
| + <meta name="viewport" content="width=device-width, initial-scale=1"> |
| + <meta charset="utf-8"> |
|
juliandoucette
2017/12/22 14:34:30
Duplicate.
ire
2017/12/22 16:29:37
Done.
|
| + <title>Adblock Plus newsletter signup form</title> |
| + <meta name="description" content="A newsletter sign up form, so users can stay up to date with all things related to Adblock Plus."> |
| + |
| + <!-- Resources --> |
| + <link rel="stylesheet" type="text/css" href="css/main.min.css"> |
| +</head> |
| +<body> |
| + <div class="outer-container"> |
|
juliandoucette
2017/12/22 14:34:28
NIT: This has more to do with vertical alignment t
ire
2017/12/22 16:29:36
I don't think the word ".container" refers horizon
|
| + <div class="container phablet-width"> |
| + |
| + <header id="page-header"> |
| + <figure> |
|
juliandoucette
2017/12/22 14:34:30
TOL: I think this markup makes sense. But I'm not
ire
2017/12/22 16:29:36
It makes sense to me. I'll look into the figcaptio
|
| + <img src="img/abp-logo.png" srcset="img/abp-logo.svg 2x" alt="ABP inside red octagon"> |
|
juliandoucette
2017/12/22 14:34:29
NIT: The one that you are using looks better than
ire
2017/12/22 16:29:37
I'm actually using the logo from the adblockplusui
|
| + <figcaption>Adblock <strong>Plus</strong></figcaption> |
| + </figure> |
| + <h1 class="lead"><strong>Sign up for the Adblock Plus newsletter</strong></h1> |
|
juliandoucette
2017/12/22 14:34:28
NIT: I think heading emphasis is enough. We can ma
juliandoucette
2017/12/22 14:34:30
NIT: This heading looks larger than that seen in t
ire
2017/12/22 16:29:37
I thought it looked better this way but I'll stick
ire
2017/12/22 16:29:38
Done.
|
| + <p>Stay up to date with all things Adblock Plus</p> |
| + </header> |
| + |
| + <form id="sign-up"> |
|
juliandoucette
2017/12/22 14:34:28
This form doesn't actually work. I can't approve u
ire
2017/12/22 16:29:36
As I mentioned in the review description, this was
|
| + <label for="email">Email Address *</label> |
|
juliandoucette
2017/12/22 14:34:28
NIT: There seems to be more space below these in t
ire
2017/12/22 16:29:37
Done.
|
| + <input type="email" id="email" name="email" required> |
| + <span class="error-message">Please enter a valid email address</span> |
|
juliandoucette
2017/12/22 14:34:29
NIT/Suggest: <div> instead of <span> to make it cl
ire
2017/12/22 16:29:36
Done.
|
| + |
| + <label for="fullname">Full name</label> |
| + <input type="text" id="fullname" name="fullname"> |
| + |
| + <button type="submit" class="secondary">Sign Up</button> |
| + </form> |
| + <footer id="page-footer"> |
| + <a href="https://eyeo.com/en/privacy" target="_blank">Privacy Policy</a> |
| + </footer> |
| + </div> |
| + </div> |
| +</body> |
| +</html> |
« no previous file with comments
|
« img/abp-logo.svg ('k')
|
package.json » ('j')
|
scss/_content.scss » ('J')
