Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/templates/signup.html

Issue 29646555: Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter (Closed)
Patch Set: Update with specification changes Created Jan. 12, 2018, 1:19 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/templates/signup.html
===================================================================
new file mode 100644
--- /dev/null
+++ b/src/templates/signup.html
@@ -0,0 +1,100 @@
+<!--*******************************************************************************
+* Sign Up Page
+****************************************************************************** -->
+<!doctype html>
+<html lang="en" dir="ltr">
+<head>
+ <!-- website-defaults/includes/meta/standard -->
+ <meta charset="utf-8">
+ <meta http-equiv="x-ua-compatible" content="ie=edge">
+ <meta name="viewport" content="width=device-width, initial-scale=1">
+ <title>Newsletter Signup</title>
+ <meta name="description" content="A newsletter sign up form, so users can stay up to date with all things related to Adblock Plus.">
+
+ <!-- styles:start -->
+ <!-- styles:end -->
+
+<!--FILTER-COMMENTS-->
+</head>
+<body>
+ <div class="outer-container">
+ <div class="container phone-width content">
+
+ <header id="page-header">
+ <figure>
+ <img src="https://eyeo.com/images/backclick/abp-logo.png" srcset="https://eyeo.com/images/backclick/abp-logo.svg 2x" alt="ABP inside red octagon">
+ <figcaption>Adblock <strong>Plus</strong></figcaption>
juliandoucette 2018/01/22 19:47:55 This appears on two lines when I test?
ire 2018/01/23 08:48:12 You mean the "Plus" appears on a second line? I ca
juliandoucette 2018/01/23 17:00:47 Yes. It seems to be because there is not enough sp
+ </figure>
+
+ <!--NEW-USER-->
+ <h1>Sign up for the Adblock Plus Newsletter</h1>
+ <p>Stay up to date with all things Adblock Plus</p>
+ <p><span class="color-secondary">*</span> Indicated required details</p>
+ <!--/NEW-USER-->
+
+ <!--UNCONFIRMED--><!--SUCCESS-->
juliandoucette 2018/01/22 19:47:54 NIT: It's inconvenient that these are all visible
ire 2018/01/23 08:48:10 I agree that it's inconvenient, but I don't think
juliandoucette 2018/01/23 17:00:48 I agree with you in the short-term (hence NIT). An
+ <h1>Confirm your email</h1>
+ <p>You should have received an email with a confirmation link. Please click the link to confirm your email and subscribe</p>
juliandoucette 2018/01/22 19:47:55 NIT: Missing period according to spec
ire 2018/01/23 08:48:11 Done.
+ <!--/SUCCESS--><!--/UNCONFIRMED-->
+
+ <!--CONFIRMED--><!--SUCCESS-->
+ <h1>Thank you for subscribing to the <strong>Adblock Plus</strong> newsletter</h1>
juliandoucette 2018/01/22 19:47:55 NIT: Missing period according to spec
ire 2018/01/23 08:48:11 Done.
+ <p>We look forward to sharing our updates with you</p>
+ <!--/SUCCESS--><!--/CONFIRMED-->
+ </header>
+
+ <!--NEW-USER-->
+ <form name="abonnenten_anmeldung" action="web.subscribe?tid=14&mid=0" method="post" id="sign-up">
+
+ <div>
+ <label for="email">Email Address <abbr title="required" class="color-secondary">*</abbr></label>
+
+ <?GIS EMAIL params="id='email' type='email' class='<!--ERROR:INCORRECT-EMAIL-->invalid<!--/ERROR:INCORRECT-EMAIL--><!--ERROR:NO-EMAIL-->invalid<!--/ERROR:NO-EMAIL--><!--ALREADY-CONFIRMED--><!--ERROR-->invalid<!--/ERROR--><!--/ALREADY-CONFIRMED--><!--ERROR:ALREADY-ON-10-->invalid<!--/ERROR:ALREADY-ON-10-->' required" mandatory?>
+
+ <!--ERROR:NO-EMAIL-->
+ <div class="error-message">Please provide an email address</div>
+ <!--/ERROR:NO-EMAIL-->
+
+ <!--ERROR:INCORRECT-EMAIL-->
+ <div class="error-message">Please enter a valid email address</div>
+ <!--/ERROR:INCORRECT-EMAIL-->
+
+ <!--ERROR:ALREADY-ON-10-->
+ <div class="error-message">You have already subscribed to this newsletter</div>
+ <!--/ERROR:ALREADY-ON-10-->
+
+ <!--ALREADY-CONFIRMED--><!--ERROR-->
+ <div class="error-message">You have already subscribed to this newsletter</div>
+ <!--/ERROR--><!--/ALREADY-CONFIRMED-->
+ </div>
+
+ <div>
+ <label for="fullname">Full name</label>
+ <?GIS FULLNAME params="id='fullname'"?>
+ </div>
+
+ <!--ERROR:NO-PASSWORD-->
juliandoucette 2018/01/22 19:47:56 If we are going to include these then I think we s
ire 2018/01/23 08:48:12 Since they aren't in the spec I'll remove them for
juliandoucette 2018/01/23 17:00:47 Acknowledged.
+ <p>Error: No Password</p><br>
+ <!--/ERROR:NO-PASSWORD-->
+
+ <!--ERROR:WRONG-PASSWORD-->
+ <p>Error: Wrong Password</p><br>
+ <!--/ERROR:WRONG-PASSWORD-->
+
+ <!--ERROR:INCORRECT-PASSWORD-->
+ <p>Error: Incorrect Password</p><br>
+ <!--/ERROR:INCORRECT-PASSWORD-->
+
+ <?GIS NEWSLETTER 10 checked hidden?>
+
+ <button type="submit" class="secondary">Sign Up</button>
+ </form>
+ <footer id="page-footer">
+ <a href="https://eyeo.com/en/privacy" target="_blank" class="color-secondary">Privacy Policy</a>
+ </footer>
+ <!--/NEW-USER-->
+
+ </div>
+ </div>
+</body>
+</html>

Powered by Google App Engine
This is Rietveld