Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/background.js

Issue 29646589: Issue 6191 - Update frame structure for Chrome Web Store pages (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Combine checks Created Jan. 15, 2018, 12:07 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/background.js
===================================================================
--- a/ext/background.js
+++ b/ext/background.js
@@ -258,20 +258,24 @@
{types: ["main_frame", "sub_frame"], urls: ["http://*/*", "https://*/*"]},
["responseHeaders"]);
browser.webNavigation.onBeforeNavigate.addListener(details =>
{
// Since we can only listen for HTTP(S) responses using
// webRequest.onHeadersReceived we must update the page structure here for
// other navigations.
- let url = new URL(details.url);
- if (url.protocol != "http:" && url.protocol != "https:")
+ let {url} = details;
+ if (!(url.startsWith("http:") ||
+ url.startsWith("https:") &&
+ // Chrome doesn't dispatch webRequest.onHeadersReceived
+ // for Web Store URLs.
+ !url.startsWith("https://chrome.google.com/webstore/")))
{
- updatePageFrameStructure(details.frameId, details.tabId, details.url,
+ updatePageFrameStructure(details.frameId, details.tabId, url,
details.parentFrameId);
}
});
function forgetTab(tabId)
{
ext.pages.onRemoved._dispatch(tabId);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld