Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/geckoInfo.js.tmpl

Issue 29646592: Noissue - Drop support for Firefox 50 (Closed) Base URL: https://hg.adblockplus.org/buildtools/
Patch Set: Created Dec. 21, 2017, 2:07 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/geckoInfo.js.tmpl
===================================================================
--- a/templates/geckoInfo.js.tmpl
+++ b/templates/geckoInfo.js.tmpl
@@ -12,24 +12,13 @@
exports.platform = "gecko";
exports.platformVersion = "0";
let match = /\brv:(\d+(?:\.\d+)?)\b/.exec(navigator.userAgent);
if (match)
exports.platformVersion = match[1];
-// Firefox 50 does not support runtime.getBrowserInfo
-if ("getBrowserInfo" in browser.runtime)
+browser.runtime.getBrowserInfo().then(browserInfo =>
{
- browser.runtime.getBrowserInfo().then(browserInfo =>
- {
- exports.application = browserInfo.name.toLowerCase();
- exports.applicationVersion = browserInfo.version;
- });
-}
-else
-{
- let browserInfo = /\bFirefox\/(\S+)/.exec(navigator.userAgent);
- exports.application = "firefox";
- if (browserInfo)
- exports.applicationVersion = browserInfo[1];
-}
+ exports.application = browserInfo.name.toLowerCase();
+ exports.applicationVersion = browserInfo.version;
+});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld