Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1360)

Issue 29654555: Issue 6209 - Updated woff fonts and table status column for long texts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by saroyanm
Modified:
1 year, 4 months ago
Reviewers:
Thomas Greiner, ire
CC:
juliandoucette
Visibility:
Public.

Description

* Old fonts were missing Cyrillic Characters, so most of the fonts were rendered as Arial. * The fonts are copied from -> https://github.com/adobe-fonts/source-sans-pro/tree/release/WOFF/OTF * New fonts are around 120kb each while old fonts were around 17kb each.

Patch Set 1 #

Patch Set 2 : Updated woff2 files #

Total comments: 1

Patch Set 3 : Fixed the table status column for long text #

Total comments: 3

Patch Set 4 : Rebased #

Patch Set 5 : Added font ranges #

Total comments: 16

Patch Set 6 : Rebased #

Patch Set 7 : Separated fonts and added license #

Total comments: 5

Patch Set 8 : Addressed Thomas comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -114 lines) Patch
M desktop-options.html View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M issue-reporter.html View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mobile-options.html View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M skin/desktop-options.css View 1 2 3 4 5 6 7 3 chunks +7 lines, -38 lines 0 comments Download
A skin/fonts.css View 1 2 3 4 5 6 1 chunk +260 lines, -0 lines 0 comments Download
R skin/fonts/Source-Sans-Pro/300.woff2 View 1 2 3 4 5 6 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/300/cyrillic.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/300/cyrillic-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/300/greek.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/300/greek-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/300/latin.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/300/latin-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/300/vietnamese.woff2 View 1 2 3 4 Binary file 0 comments Download
R skin/fonts/Source-Sans-Pro/400.woff2 View 1 2 3 4 5 6 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/400/cyrillic.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/400/cyrillic-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/400/greek.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/400/greek-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/400/latin.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/400/latin-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/400/vietnamese.woff2 View 1 2 3 4 Binary file 0 comments Download
R skin/fonts/Source-Sans-Pro/700.woff2 View 1 2 3 4 5 6 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/700/cyrillic.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/700/cyrillic-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/700/greek.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/700/greek-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/700/latin.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/700/latin-ext.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/700/vietnamese.woff2 View 1 2 3 4 Binary file 0 comments Download
A skin/fonts/Source-Sans-Pro/LICENSE.txt View 1 2 3 4 5 6 1 chunk +93 lines, -0 lines 0 comments Download
R skin/fonts/SourceSansPro-Light.woff View 1 2 3 4 5 6 Binary file 0 comments Download
R skin/fonts/SourceSansPro-Regular.woff View 1 2 3 4 5 6 Binary file 0 comments Download
R skin/fonts/SourceSansPro-bold.woff View 1 2 3 4 5 6 Binary file 0 comments Download
M skin/issue-reporter.css View 1 2 3 4 5 6 2 chunks +1 line, -30 lines 0 comments Download
M skin/mobile-options.css View 1 2 3 4 5 6 2 chunks +1 line, -26 lines 0 comments Download
M skin/updates.css View 1 2 3 4 5 6 7 2 chunks +17 lines, -20 lines 0 comments Download
M updates.html View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17
saroyanm
@Thomas can you please let me know if you aware of any font compression tool ...
1 year, 6 months ago (2018-01-02 15:20:09 UTC) #1
saroyanm
https://codereview.adblockplus.org/29654555/diff/29654560/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29654560/skin/desktop-options.css#newcode23 skin/desktop-options.css:23: src: local("Ø"), url("fonts/Source-Sans-Pro/300.woff2") format("woff2"), I think we should update ...
1 year, 6 months ago (2018-01-02 15:39:23 UTC) #2
saroyanm
https://codereview.adblockplus.org/29654555/diff/29654568/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29654568/skin/desktop-options.css#newcode1002 skin/desktop-options.css:1002: -moz-margin-end: 0.5rem; I'll reflect this changes in the Specs. ...
1 year, 6 months ago (2018-01-02 17:36:11 UTC) #3
Thomas Greiner
On 2018/01/02 15:20:09, saroyanm wrote: > @Thomas can you please let me know if you ...
1 year, 6 months ago (2018-01-08 15:53:39 UTC) #4
saroyanm
On 2018/01/08 15:53:39, Thomas Greiner wrote: > On 2018/01/02 15:20:09, saroyanm wrote: > > @Thomas ...
1 year, 6 months ago (2018-01-10 10:49:21 UTC) #5
saroyanm
https://codereview.adblockplus.org/29654555/diff/29654568/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29654568/skin/desktop-options.css#newcode23 skin/desktop-options.css:23: src: local("Ø"), url("fonts/Source-Sans-Pro/300.woff2") format("woff2"), Adjust as was mentioned in ...
1 year, 6 months ago (2018-01-10 11:03:20 UTC) #6
saroyanm
New patch uploaded. https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css#newcode18 skin/desktop-options.css:18: /* cyrillic-ext */ I added fonts ...
1 year, 5 months ago (2018-01-29 16:16:19 UTC) #7
Thomas Greiner
https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css#newcode18 skin/desktop-options.css:18: /* cyrillic-ext */ On 2018/01/29 16:16:17, saroyanm wrote: > ...
1 year, 5 months ago (2018-02-14 17:13:46 UTC) #8
saroyanm
https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css#newcode18 skin/desktop-options.css:18: /* cyrillic-ext */ On 2018/02/14 17:13:45, Thomas Greiner wrote: ...
1 year, 5 months ago (2018-02-14 18:30:05 UTC) #9
Thomas Greiner
https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css#newcode18 skin/desktop-options.css:18: /* cyrillic-ext */ On 2018/02/14 18:30:04, saroyanm wrote: > ...
1 year, 5 months ago (2018-02-15 12:17:07 UTC) #10
saroyanm
@Thomas I think this issue looks more complex than it has seemed initially, I'll suggest ...
1 year, 5 months ago (2018-02-15 18:47:19 UTC) #11
saroyanm
New patch is uploaded, ready for the review. https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29683655/skin/desktop-options.css#newcode18 skin/desktop-options.css:18: /* ...
1 year, 5 months ago (2018-02-16 21:02:57 UTC) #12
Thomas Greiner
https://codereview.adblockplus.org/29654555/diff/29699667/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29699667/skin/desktop-options.css#newcode18 skin/desktop-options.css:18: /* cyrillic-ext */ Detail: These rules are already included ...
1 year, 5 months ago (2018-02-19 14:45:52 UTC) #13
saroyanm
Ready for review. https://codereview.adblockplus.org/29654555/diff/29699667/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29654555/diff/29699667/skin/desktop-options.css#newcode18 skin/desktop-options.css:18: /* cyrillic-ext */ On 2018/02/19 14:45:51, ...
1 year, 5 months ago (2018-02-20 15:30:10 UTC) #14
Thomas Greiner
Let's also remove the duplicated font files which are no longer being used after this ...
1 year, 4 months ago (2018-02-21 12:38:24 UTC) #15
saroyanm
On 2018/02/21 12:38:24, Thomas Greiner wrote: > Let's also remove the duplicated font files which ...
1 year, 4 months ago (2018-02-21 12:42:29 UTC) #16
Thomas Greiner
1 year, 4 months ago (2018-02-21 12:48:39 UTC) #17
On 2018/02/21 12:42:29, saroyanm wrote:
> I think I've removed them, If I don't miss something.

You're right, I missed the "R" next to them. Everything's fine then. :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5